From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117F6C63793 for ; Thu, 22 Jul 2021 14:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96646135B for ; Thu, 22 Jul 2021 14:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232347AbhGVNgj convert rfc822-to-8bit (ORCPT ); Thu, 22 Jul 2021 09:36:39 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:45273 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbhGVNgj (ORCPT ); Thu, 22 Jul 2021 09:36:39 -0400 Received: from smtpclient.apple (p5b3d2eb8.dip0.t-ipconnect.de [91.61.46.184]) by mail.holtmann.org (Postfix) with ESMTPSA id CD78ACECDD; Thu, 22 Jul 2021 16:17:12 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH] Bluetooth: btusb: Fix a unspported condition to set available debug features From: Marcel Holtmann In-Reply-To: <20210709134625.1235015-1-jun.miao@windriver.com> Date: Thu, 22 Jul 2021 16:17:12 +0200 Cc: matthias.bgg@gmail.com, Johan Hedberg , Luiz Augusto von Dentz , Bluetooth Kernel Mailing List , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 8BIT Message-Id: <3A8EB08F-C6D1-4B92-B72B-265C49DC5940@holtmann.org> References: <20210709134625.1235015-1-jun.miao@windriver.com> To: Jun Miao X-Mailer: Apple Mail (2.3654.100.0.2.22) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Jun, > When reading the support debug features failed, there are not available > features init. Continue to set the debug features is illogical, we should > skip btintel_set_debug_features(), even if check it by "if (!features)". > > Fixes: c453b10c2b28 ("Bluetooth: btusb: Configure Intel debug feature based on > available support") > Signed-off-by: Jun Miao > --- > drivers/bluetooth/btusb.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel