From: Marcel Holtmann <marcel@holtmann.org>
To: mcchou@chromium.org
Cc: linux-bluetooth@vger.kernel.org,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
josephsih@chromium.org, ortuno@chromium.org,
Eric Caruso <ejcaruso@chromium.org>
Subject: Re: [PATCH] device: Add device type property
Date: Thu, 9 Feb 2017 08:37:41 +0100 [thread overview]
Message-ID: <3CF37350-C135-465D-9075-C1ED3B0D6F60@holtmann.org> (raw)
In-Reply-To: <20170209010508.150518-1-mcchou@chromium.org>
Hi Eric,
> This allows us to gather information about whether a device
> supports BR/EDR, BLE, or both. It appears as DBus Property
> "Type" on the org.bluez.Device1 interface.
>
> This is tested with the following steps:
> Scan for devices and request the type property of a specific remote device,
> using:
> # dbus-send --print-reply --system --dest=org.bluez <obj path> \
> org.freedesktop.DBus.Properties.Get \
> string:org.bluez.Device1 string:Type
> or request the type of all remote devices, using:
> # dbus-send --print-reply --system --dest=org.bluez / \
> org.freedesktop.DBus.ObjectManager.GetManagedObjects | \
> grep -B1 -A2 Type
> and check for "BR/EDR", "LE", and "DUAL"
> ---
> doc/device-api.txt | 5 +++++
> src/device.c | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 36 insertions(+)
>
> diff --git a/doc/device-api.txt b/doc/device-api.txt
> index 13b28818e..2f3100cd5 100644
> --- a/doc/device-api.txt
> +++ b/doc/device-api.txt
> @@ -141,6 +141,11 @@ Properties string Address [readonly]
>
> The Bluetooth class of device of the remote device.
>
> + string Type [readonly, optional]
> +
> + The carriers supported by this remote device. If it
> + exists, it can be one of "BR/EDR", "LE", or "DUAL".
> +
I don’t like upper-case for values of this type. We have kept them normally all lower-case.
Anyhow, actually you can deduct this information already from existing Class and Appearance values. If Class exists it is BR/EDR and if Appearance exists it is LE. If both exist it is dual-mode device. Only trick part might be that Appearance is optional, but we could just fill it in with some generic value. Would need to look that up.
Regards
Marcel
next prev parent reply other threads:[~2017-02-09 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 1:05 [PATCH] device: Add device type property mcchou
2017-02-09 7:37 ` Marcel Holtmann [this message]
2017-02-09 8:07 ` Szymon Janc
2017-02-09 9:40 ` Luiz Augusto von Dentz
2020-04-01 22:13 Sonny Sasaka
2020-04-09 18:11 ` Marcel Holtmann
2020-04-09 21:05 ` Sonny Sasaka
2020-04-10 6:51 ` Marcel Holtmann
2020-05-19 23:12 ` Sonny Sasaka
2020-05-20 6:49 ` Marcel Holtmann
2020-05-21 1:07 ` Sonny Sasaka
2020-05-21 7:01 ` Marcel Holtmann
2020-05-21 16:24 ` Sonny Sasaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CF37350-C135-465D-9075-C1ED3B0D6F60@holtmann.org \
--to=marcel@holtmann.org \
--cc=ejcaruso@chromium.org \
--cc=josephsih@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=mcchou@chromium.org \
--cc=ortuno@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).