From: Marcel Holtmann <marcel@holtmann.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Sathish Narsimman <sathish.narasimman@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"
Date: Sun, 4 Oct 2020 18:59:24 +0200 [thread overview]
Message-ID: <3F7BDD50-DEA3-4CB0-A9A0-69E7EE2923D5@holtmann.org> (raw)
In-Reply-To: <20201004105124.GA2429@kroah.com>
Hi Greg,
>>>>> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
>>>>> breaks all bluetooth connections on my machine.
>>>>>
>>>>> Cc: Marcel Holtmann <marcel@holtmann.org>
>>>>> Cc: Sathish Narsimman <sathish.narasimman@intel.com>
>>>>> Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
>>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>>> ---
>>>>> net/bluetooth/hci_request.c | 41 ++-----------------------------------
>>>>> 1 file changed, 2 insertions(+), 39 deletions(-)
>>>>>
>>>>> This has been bugging me for since 5.9-rc1, when all bluetooth devices
>>>>> stopped working on my desktop system. I finally got the time to do
>>>>> bisection today, and it came down to this patch. Reverting it on top of
>>>>> 5.9-rc7 restored bluetooth devices and now my input devices properly
>>>>> work.
>>>>>
>>>>> As it's almost 5.9-final, any chance this can be merged now to fix the
>>>>> issue?
>>>>
>>>> can you be specific what breaks since our guys and I also think the
>>>> ChromeOS guys have been testing these series of patches heavily.
>>>
>>> My bluetooth trackball does not connect at all. With this reverted, it
>>> all "just works".
>>>
>>> Same I think for a Bluetooth headset, can check that again if you really
>>> need me to, but the trackball is reliable here.
>>>
>>>> When you run btmon does it indicate any errors?
>>>
>>> How do I run it and where are the errors displayed?
>>
>> you can do btmon -w trace.log and just let it run like tcdpump.
>
> Ok, attached.
>
> The device is not connecting, and then I open the gnome bluetooth dialog
> and it scans for devices in the area, but does not connect to my
> existing devices at all.
>
> Any ideas?
the trace file is from -rc7 or from -rc7 with this patch reverted?
I asked, because I see no hint that anything goes wrong. However I have a suspicion if you bisected it to this patch.
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index e0269192f2e5..94c0daa9f28d 100644
--- a/net/bluetooth/hci_request.c
+++ b/net/bluetooth/hci_request.c
@@ -732,7 +732,7 @@ static int add_to_white_list(struct hci_request *req,
return -1;
/* White list can not be used with RPAs */
- if (!allow_rpa && !use_ll_privacy(hdev) &&
+ if (!allow_rpa &&
hci_find_irk_by_addr(hdev, ¶ms->addr, params->addr_type)) {
return -1;
}
@@ -812,7 +812,7 @@ static u8 update_white_list(struct hci_request *req)
}
/* White list can not be used with RPAs */
- if (!allow_rpa && !use_ll_privacy(hdev) &&
+ if (!allow_rpa &&
hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {
return 0x00;
}
If you just do the above, does thing work for you again?
My suspicion is that the use_ll_privacy check is the wrong one here. It only checks if hardware feature is available, not if it is also enabled.
Regards
Marcel
next prev parent reply other threads:[~2020-10-04 17:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 13:54 [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" Greg Kroah-Hartman
2020-10-03 15:51 ` Marcel Holtmann
2020-10-03 16:07 ` Greg Kroah-Hartman
2020-10-03 18:33 ` Marcel Holtmann
2020-10-04 10:51 ` Greg Kroah-Hartman
2020-10-04 10:53 ` Greg Kroah-Hartman
2020-10-04 12:17 ` Bastien Nocera
2020-10-04 13:18 ` Greg Kroah-Hartman
2020-10-04 13:23 ` Bastien Nocera
2020-10-05 8:29 ` Greg Kroah-Hartman
2020-10-04 16:59 ` Marcel Holtmann [this message]
2020-10-05 8:36 ` Greg Kroah-Hartman
2020-10-05 12:19 ` Marcel Holtmann
2020-10-05 12:40 ` Greg Kroah-Hartman
2020-10-05 15:44 ` Marcel Holtmann
2020-10-05 16:11 ` Greg Kroah-Hartman
2020-10-05 17:14 ` Marcel Holtmann
2020-10-05 17:38 ` Greg Kroah-Hartman
2020-10-05 18:02 ` Greg Kroah-Hartman
2020-10-05 18:58 ` Marcel Holtmann
2020-10-07 13:23 ` Greg Kroah-Hartman
2020-10-07 13:40 ` Greg Kroah-Hartman
2020-10-07 13:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F7BDD50-DEA3-4CB0-A9A0-69E7EE2923D5@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathish.narasimman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).