Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v5 02/11] Bluetooth: Add initial implementation of CIS connections
Date: Wed, 15 Jan 2020 22:18:07 +0100
Message-ID: <3FDBB982-CE2E-431D-8FA1-61C2DA19E153@holtmann.org> (raw)
In-Reply-To: <20200115210221.13096-3-luiz.dentz@gmail.com>

Hi Luiz,

> This adds the initial implementation of CIS connections along with a new
> socket type BTPROTO_ISO to make use of it.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> include/net/bluetooth/bluetooth.h |   35 +
> include/net/bluetooth/hci_core.h  |   68 +-
> include/net/bluetooth/hci_sock.h  |    2 +
> include/net/bluetooth/iso.h       |   36 +
> net/bluetooth/Kconfig             |    1 +
> net/bluetooth/Makefile            |    1 +
> net/bluetooth/af_bluetooth.c      |   12 +-
> net/bluetooth/hci_conn.c          |  169 ++++
> net/bluetooth/hci_core.c          |  243 ++++-
> net/bluetooth/hci_event.c         |  230 +++++
> net/bluetooth/iso.c               | 1393 +++++++++++++++++++++++++++++
> 11 files changed, 2138 insertions(+), 52 deletions(-)
> create mode 100644 include/net/bluetooth/iso.h
> create mode 100644 net/bluetooth/iso.c
> 
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index e42bb8e03c09..af969f250b7d 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -53,6 +53,8 @@
> #define BTPROTO_CMTP	5
> #define BTPROTO_HIDP	6
> #define BTPROTO_AVDTP	7
> +#define BTPROTO_ISO	8
> +#define BTPROTO_LAST	BTPROTO_ISO

I prefer to add this patch in a second phase since it is actually userspace API and I want to think this through more carefully. We might need to split this out in the ISO packet processing and ISO sockets.

Regards

Marcel


  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 21:02 [PATCH v5 00/11] Bluetooth 5.2 initial support Luiz Augusto von Dentz
2020-01-15 21:02 ` [PATCH v5 01/11] Bluetooth: Add definitions for CIS connections Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 02/11] Bluetooth: Add initial implementation of " Luiz Augusto von Dentz
2020-01-15 21:18   ` Marcel Holtmann [this message]
2020-01-15 21:02 ` [PATCH v5 03/11] Bluetooth: L2CAP: Add definitions for Enhanced Credit Based Mode Luiz Augusto von Dentz
2020-01-15 21:20   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 04/11] Bluetooth: L2CAP: Add initial code " Luiz Augusto von Dentz
2020-01-15 21:02 ` [PATCH v5 05/11] Bluetooth: L2CAP: Rename FLAG_LE_CONN_REQ_SENT to FLAG_LE_FLOWCTL_CONN_REQ_SENT Luiz Augusto von Dentz
2020-01-15 21:26   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 06/11] Bluetooth: hci_vhci: Add support for ISO packets Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 07/11] Bluetooth: monitor: " Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 08/11] Bluetooth: Make use of __check_timeout on hci_sched_le Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 09/11] Bluetooth: hci_h4: Add support for ISO packets Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 10/11] Bluetooth: hci_h5: " Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann
2020-01-15 21:02 ` [PATCH v5 11/11] Bluetooth: btsdio: Check for valid packet type Luiz Augusto von Dentz
2020-01-15 21:25   ` Marcel Holtmann

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FDBB982-CE2E-431D-8FA1-61C2DA19E153@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git