From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8129AC3524D for ; Mon, 3 Feb 2020 08:23:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 574D920658 for ; Mon, 3 Feb 2020 08:23:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="da7n1AvY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727311AbgBCIXJ (ORCPT ); Mon, 3 Feb 2020 03:23:09 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:12634 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgBCIXI (ORCPT ); Mon, 3 Feb 2020 03:23:08 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580718187; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=RSjEiJ0ttdkS4GFK/NmrKRk8pctFGBmoDIg5s6bhlOg=; b=da7n1AvY1a7V/37oqTufbUlJcIAEqcV6fTE1T9I9ucHCTpsLO3Yz8vz9DwqUm9NmEHVvTZLh zBJsF3Ot2fW3fhbO2wt2AGm9Q3q3dKIVLHmPR8aocdc65OC8qiSsOTV5/xCzKDtXN9rlaUPP gvu1nGQdjyXRumfcQWK5b7sFpTg= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI2MTA3ZSIsICJsaW51eC1ibHVldG9vdGhAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e37d86a.7fc837d1c3e8-smtp-out-n03; Mon, 03 Feb 2020 08:23:06 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C5B3FC447A0; Mon, 3 Feb 2020 08:23:05 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: gubbaven) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1FD62C43383; Mon, 3 Feb 2020 08:23:05 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 03 Feb 2020 13:53:05 +0530 From: gubbaven@codeaurora.org To: Matthias Kaehlcke Cc: marcel@holtmann.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, robh@kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, tientzu@chromium.org, seanpaul@chromium.org, rjliao@codeaurora.org, yshavit@google.com, Rob Herring , Frank Rowand , devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991 In-Reply-To: <20200131223626.GA237926@google.com> References: <1580456335-7317-1-git-send-email-gubbaven@codeaurora.org> <1580456335-7317-2-git-send-email-gubbaven@codeaurora.org> <20200131223626.GA237926@google.com> Message-ID: <3a9f33a4e8e6f2ac2ebd286e31e5836f@codeaurora.org> X-Sender: gubbaven@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Matthias, On 2020-02-01 04:06, Matthias Kaehlcke wrote: > + DT folks > > On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana > Gubba wrote: >> Add compatible string for the Qualcomm WCN3991 Bluetooth controller >> >> Signed-off-by: Venkata Lakshmi Narayana Gubba >> >> --- >> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> index 68b67d9..e72045d 100644 >> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> @@ -11,6 +11,7 @@ Required properties: >> - compatible: should contain one of the following: >> * "qcom,qca6174-bt" >> * "qcom,wcn3990-bt" >> + * "qcom,wcn3991-bt" >> * "qcom,wcn3998-bt" >> >> Optional properties for compatible string qcom,qca6174-bt: >> @@ -30,6 +31,7 @@ Optional properties for compatible string >> qcom,wcn399x-bt: >> >> - max-speed: see >> Documentation/devicetree/bindings/serial/slave-device.txt >> - firmware-name: specify the name of nvm firmware to load >> + - clocks: clock provided to the controller >> >> Examples: >> >> @@ -56,5 +58,6 @@ serial@898000 { >> vddch0-supply = <&vreg_l25a_3p3>; >> max-speed = <3200000>; >> firmware-name = "crnv21.bin"; >> + clocks = <&rpmhcc>; > > That specifies a clock controller, not a clock. > > For a device with the SC7180 SoC we use this: > > clocks = <&rpmhcc RPMH_RF_CLK2>; [Venkata] : Sure, we will update in next patch set. > >> }; >> }; Regards, Venkata.