From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
Date: Fri, 28 Dec 2018 13:19:02 +0530 [thread overview]
Message-ID: <3ff6a55912a5b4f9462484d90bab3084@codeaurora.org> (raw)
In-Reply-To: <20181227202514.GK261387@google.com>
Hi Matthias,
On 2018-12-28 01:55, Matthias Kaehlcke wrote:
> On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote:
>> During initalization of wcn3990, we observed UART is reading some
>> stray bytes on the Rx line. This is logging Frame reassembly errors
>> on the serial console. This could be because of tristate of Tx line
>> of wcn3990 during boot up.
>
> My testing suggests that this change is not needed if the Rx line of
> the SoC/AP is configured with a pull-up. We'd probably all prefer not
> to have this change if there's a neater way to address the garbage
> data. Could you test with adding the pull-up and dropping this patch
> on your side?
>
> Thanks
>
> Matthias
Thanks a lot it worked to me. will drop this patch.
--
Regards
Balakrishna.
next prev parent reply other threads:[~2018-12-28 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 7:31 [PATCH v6 0/6] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 1/6] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-27 20:18 ` Matthias Kaehlcke
2018-12-28 7:11 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 2/6] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Balakrishna Godavarthi
2018-12-27 20:25 ` Matthias Kaehlcke
2018-12-28 7:49 ` Balakrishna Godavarthi [this message]
2018-12-27 7:31 ` [PATCH v6 4/6] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 5/6] Bluetooth: hci_qca: Update baudrate change wait time for wcn3990 Balakrishna Godavarthi
2018-12-27 21:00 ` Matthias Kaehlcke
2018-12-28 11:25 ` Balakrishna Godavarthi
2018-12-27 7:31 ` [PATCH v6 6/6] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff6a55912a5b4f9462484d90bab3084@codeaurora.org \
--to=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).