From: Marcel Holtmann <marcel@holtmann.org> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v5 03/11] Bluetooth: L2CAP: Add definitions for Enhanced Credit Based Mode Date: Wed, 15 Jan 2020 22:20:00 +0100 Message-ID: <42BFE5DB-E1CA-430A-B86A-A37758D999B7@holtmann.org> (raw) In-Reply-To: <20200115210221.13096-4-luiz.dentz@gmail.com> Hi Luiz, > This introduces the definitions for the new L2CAP mode called Enhanced > Credit Based Mode. > > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > --- > include/net/bluetooth/l2cap.h | 41 +++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > index 093aedebdf0c..d85fb2c8e6eb 100644 > --- a/include/net/bluetooth/l2cap.h > +++ b/include/net/bluetooth/l2cap.h > @@ -119,6 +119,11 @@ struct l2cap_conninfo { > #define L2CAP_LE_CONN_REQ 0x14 > #define L2CAP_LE_CONN_RSP 0x15 > #define L2CAP_LE_CREDITS 0x16 > +#define L2CAP_EXT_FLOWCTL_CONN_REQ 0x17 > +#define L2CAP_EXT_FLOWCTL_CONN_RSP 0x18 > +#define L2CAP_EXT_FLOWCTL_RECONF_REQ 0x19 > +#define L2CAP_EXT_FLOWCTL_RECONF_RSP 0x1a > + the extra empty line here is not needed. > > /* L2CAP extended feature mask */ > #define L2CAP_FEAT_FLOWCTL 0x00000001 > @@ -360,6 +365,8 @@ struct l2cap_conf_rfc { > */ > #define L2CAP_MODE_LE_FLOWCTL 0x80 > > +#define L2CAP_MODE_EXT_FLOWCTL 0x81 > + So while for the mode, I prefer using EXT_FLOWCTL, but internally I would use ECRED to keep the constants and struct names short. > struct l2cap_conf_efs { > __u8 id; > __u8 stype; > @@ -483,6 +490,39 @@ struct l2cap_le_credits { > __le16 credits; > } __packed; > > +#define L2CAP_EXT_FLOWCTL_MIN_MTU 64 > +#define L2CAP_EXT_FLOWCTL_MIN_MPS 64 > + > +struct l2cap_ext_flowctl_conn_req { > + __le16 psm; > + __le16 mtu; > + __le16 mps; > + __le16 credits; > + __le16 scid[0]; > +} __packed; > + > +struct l2cap_ext_flowctl_conn_rsp { > + __le16 mtu; > + __le16 mps; > + __le16 credits; > + __le16 result; > + __le16 dcid[0]; > +}; > + > +struct l2cap_ext_flowctl_reconf_req { > + __le16 mtu; > + __le16 mps; > + __le16 scid[0]; > +} __packed; > + > +#define L2CAP_RECONF_SUCCESS 0x0000 > +#define L2CAP_RECONF_INVALID_MTU 0x0001 > +#define L2CAP_RECONF_INVALID_MPS 0x0002 > + > +struct l2cap_ext_flowctl_reconf_rsp { > + __le16 result; > +} __packed; > + > /* ----- L2CAP channels and connections ----- */ > struct l2cap_seq_list { > __u16 head; > @@ -724,6 +764,7 @@ enum { > FLAG_EFS_ENABLE, > FLAG_DEFER_SETUP, > FLAG_LE_CONN_REQ_SENT, > + FLAG_EXT_FLOWCTL_CONN_REQ_SENT, I know that I said use EXT_FLOWCTL here, but I think internally in the kernel we should use ECRED. Otherwise the code becomes hard to read. Regards Marcel
next prev parent reply index Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 21:02 [PATCH v5 00/11] Bluetooth 5.2 initial support Luiz Augusto von Dentz 2020-01-15 21:02 ` [PATCH v5 01/11] Bluetooth: Add definitions for CIS connections Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 02/11] Bluetooth: Add initial implementation of " Luiz Augusto von Dentz 2020-01-15 21:18 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 03/11] Bluetooth: L2CAP: Add definitions for Enhanced Credit Based Mode Luiz Augusto von Dentz 2020-01-15 21:20 ` Marcel Holtmann [this message] 2020-01-15 21:02 ` [PATCH v5 04/11] Bluetooth: L2CAP: Add initial code " Luiz Augusto von Dentz 2020-01-15 21:02 ` [PATCH v5 05/11] Bluetooth: L2CAP: Rename FLAG_LE_CONN_REQ_SENT to FLAG_LE_FLOWCTL_CONN_REQ_SENT Luiz Augusto von Dentz 2020-01-15 21:26 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 06/11] Bluetooth: hci_vhci: Add support for ISO packets Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 07/11] Bluetooth: monitor: " Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 08/11] Bluetooth: Make use of __check_timeout on hci_sched_le Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 09/11] Bluetooth: hci_h4: Add support for ISO packets Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 10/11] Bluetooth: hci_h5: " Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann 2020-01-15 21:02 ` [PATCH v5 11/11] Bluetooth: btsdio: Check for valid packet type Luiz Augusto von Dentz 2020-01-15 21:25 ` Marcel Holtmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=42BFE5DB-E1CA-430A-B86A-A37758D999B7@holtmann.org \ --to=marcel@holtmann.org \ --cc=linux-bluetooth@vger.kernel.org \ --cc=luiz.dentz@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Bluetooth Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \ linux-bluetooth@vger.kernel.org public-inbox-index linux-bluetooth Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth AGPL code for this site: git clone https://public-inbox.org/public-inbox.git