linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joey Corleone <joey.corleone@mail.ru>
To: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync
Date: Tue, 10 May 2022 12:36:00 +0200	[thread overview]
Message-ID: <44f9b7f2-ac5f-55e9-e72b-cebe1d9bda80@mail.ru> (raw)
In-Reply-To: <46FADD2F-2B35-4CC7-BC01-CACB81FC6FAE@holtmann.org>

On 24.02.22 21:08, Marcel Holtmann wrote:
> Hi Luiz,
> 
>> hci_update_accept_list_sync is returning the filter based on the error
>> but that gets overwritten by hci_le_set_addr_resolution_enable_sync
>> return instead of using the actual result of the likes of
>> hci_le_add_accept_list_sync which was intended.
>>
>> Fixes: ad383c2c65a5b ("Bluetooth: hci_sync: Enable advertising when LL privacy is enabled")
>> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>> ---
>> v2: Use u8 filter_policy instead of int ret as variable to store the result.
>>
>> net/bluetooth/hci_sync.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> patch has been applied to bluetooth-stable tree.
> 
> Regards
> 
> Marcel

Just to put you in the loop in case you have not noticed it yet: there 
seems to be some kind of regression introduced by this patch. See 
comment #5 of ticket 215768 where Damien Thébault bisected the kernel [1].

Joey

[1] https://bugzilla.kernel.org/show_bug.cgi?id=215768#c5

  reply	other threads:[~2022-05-10 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 15:11 Luiz Augusto von Dentz
2022-02-24 16:04 ` [v2] " bluez.test.bot
2022-02-24 20:08 ` [PATCH v2] " Marcel Holtmann
2022-05-10 10:36   ` Joey Corleone [this message]
2022-05-10 15:29     ` Thorsten Leemhuis
2022-05-16 12:40       ` [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync #forregzbot Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44f9b7f2-ac5f-55e9-e72b-cebe1d9bda80@mail.ru \
    --to=joey.corleone@mail.ru \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=regressions@lists.linux.dev \
    --subject='Re: [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).