From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEB1FA372C for ; Fri, 8 Nov 2019 06:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 998BD20865 for ; Fri, 8 Nov 2019 06:12:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729816AbfKHGMH convert rfc822-to-8bit (ORCPT ); Fri, 8 Nov 2019 01:12:07 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:43990 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbfKHGMH (ORCPT ); Fri, 8 Nov 2019 01:12:07 -0500 Received: from marcel-macpro.fritz.box (p5B3D2BA4.dip0.t-ipconnect.de [91.61.43.164]) by mail.holtmann.org (Postfix) with ESMTPSA id D24F8CED12; Fri, 8 Nov 2019 07:21:09 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: [PATCH v2 4/4] dt-bindings: net: broadcom-bluetooth: Add pcm config From: Marcel Holtmann In-Reply-To: <20191107232713.48577-5-abhishekpandit@chromium.org> Date: Fri, 8 Nov 2019 07:12:05 +0100 Cc: Johan Hedberg , Rob Herring , linux-bluetooth@vger.kernel.org, dianders@chromium.org, devicetree@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ondrej Jirman , Mark Rutland , Chen-Yu Tsai Content-Transfer-Encoding: 8BIT Message-Id: <48D0B4BB-2819-4C4D-B52D-4727FB344C19@holtmann.org> References: <20191107232713.48577-1-abhishekpandit@chromium.org> <20191107232713.48577-5-abhishekpandit@chromium.org> To: Abhishek Pandit-Subedi X-Mailer: Apple Mail (2.3601.0.10) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Abhishek, > Add documentation for pcm parameters. > > Signed-off-by: Abhishek Pandit-Subedi > > --- > > Changes in v2: > - Use match data to disallow baudrate setting > - Parse pcm parameters by name instead of as a byte string > - Fix prefix for dt-bindings commit > > .../devicetree/bindings/net/broadcom-bluetooth.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > index c749dc297624..b5de8a6a3980 100644 > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > @@ -29,6 +29,11 @@ Optional properties: > - "lpo": external low power 32.768 kHz clock > - vbat-supply: phandle to regulator supply for VBAT > - vddio-supply: phandle to regulator supply for VDDIO > + - brcm,sco-routing: 0-3 (PCM, Transport, Codec, I2S) > + - brcm,pcm-interface-rate: 0-4 (128KBps, 256KBps, 512KBps, 1024KBps, 2048KBps) > + - brcm,pcm-frame-type: 0-1 (short, long) > + - brcm,pcm-sync-mode: 0-1 (slave, master) > + - brcm,pcm-clock-mode: 0-1 (slave, master) should we do brcm,bt-sco-routing etc. Regards Marcel