From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696D3C2D0F8 for ; Wed, 13 May 2020 07:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EEAB2078C for ; Wed, 13 May 2020 07:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730131AbgEMH2J (ORCPT ); Wed, 13 May 2020 03:28:09 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:45716 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728490AbgEMH2J (ORCPT ); Wed, 13 May 2020 03:28:09 -0400 Received: from [192.168.1.91] (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id EA86BCED09; Wed, 13 May 2020 09:37:50 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] Bluetooth: serdev: Constify serdev_device_ops From: Marcel Holtmann In-Reply-To: <20200509131719.5681-1-rikard.falkeborn@gmail.com> Date: Wed, 13 May 2020 09:28:08 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <4B316DC7-D034-483A-A461-2BF2CC4C2565@holtmann.org> References: <20200509131719.5681-1-rikard.falkeborn@gmail.com> To: Rikard Falkeborn X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Rikard, > serdev_device_ops is not modified and can be const. Also, remove the > unneeded declaration of it. > > Output from the file command before and after: > > Before: > text data bss dec hex filename > 7192 2408 192 9792 2640 drivers/bluetooth/hci_serdev.o > > After: > text data bss dec hex filename > 7256 2344 192 9792 2640 drivers/bluetooth/hci_serdev.o > > Signed-off-by: Rikard Falkeborn > --- > drivers/bluetooth/hci_serdev.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel