linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Carey Sonsino <csonsino@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	Andreas Kemnade <andreas@kemnade.info>,
	Jamie Mccrae <Jamie.Mccrae@lairdconnect.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/1] bluetooth: update default BLE connection params
Date: Thu, 5 Sep 2019 17:34:03 +0200	[thread overview]
Message-ID: <4BFC2A23-1D8A-4021-BB74-418A13676E65@holtmann.org> (raw)
In-Reply-To: <705dbccb-58a9-7adc-8430-c16b395c27e5@gmail.com>

Hi Carey,

> Update the default BLE connection parameters.
> 
> Commit c49a8682fc5d298d44e8d911f4fa14690ea9485e introduced a bounds
> check on connection interval update requests, but the default min/max
> values were left at 24-40 (30-50ms) which caused problems for devices
> that want to negotiate connection intervals outside of those bounds.
> 
> Setting the default min/max connection interval to the full allowable
> range in the bluetooth specification restores the default Linux behavior
> of allowing remote devices to negotiate their desired connection
> interval, while still permitting the system administrator to later
> narrow the range.
> 
> The default supervision timeout must also be modified to accommodate
> the max connection interval increase.  The new default value meets the
> requirements of the bluetooth specification and the conditions in
> the hci_check_conn_params function.
> 
> The downside to modifying the default supervision timeout is that
> it will take longer (about 10 seconds) to detect a link loss condition.
> 
> Fixes c49a8682fc5d: (validate BLE connection interval updates)

I decided to revert c49a8682fc5d and we need an overall better solution for handling connection parameters.

Regards

Marcel


  reply	other threads:[~2019-09-05 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 21:20 [PATCH 1/1] bluetooth: update default BLE connection params Carey Sonsino
2019-09-05 15:34 ` Marcel Holtmann [this message]
2019-09-20  9:11   ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFC2A23-1D8A-4021-BB74-418A13676E65@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=Jamie.Mccrae@lairdconnect.com \
    --cc=andreas@kemnade.info \
    --cc=csonsino@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).