From: Marcel Holtmann <marcel@holtmann.org>
To: Manish Mandlik <mmandlik@google.com>
Cc: Yoni Shavit <yshavit@chromium.org>,
Alain Michaud <alainm@chromium.org>,
Miao-chen Chou <mcchou@chromium.org>,
linux-bluetooth@vger.kernel.org,
Dmitry Grinberg <dmitrygr@google.com>,
"David S. Miller" <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] Bluetooth: Do not cancel advertising when starting a scan
Date: Wed, 18 Mar 2020 12:26:10 +0100 [thread overview]
Message-ID: <4DF7C709-1AD3-42FF-A0C2-EF488D82F083@holtmann.org> (raw)
In-Reply-To: <20200316224023.1.I002569822232363cfbb5af1f33a293ea390c24c7@changeid>
Hi Manish,
> BlueZ cancels adv when starting a scan, but does not cancel a scan when
> starting to adv. Neither is required, so this brings both to a
> consistent state (of not affecting each other). Some very rare (I've
> never seen one) BT 4.0 chips will fail to do both at once. Even this is
> ok since the command that will fail will be the second one, and thus the
> common sense logic of first-come-first-served is preserved for BLE
> requests.
>
> Signed-off-by: Dmitry Grinberg <dmitrygr@google.com>
> Signed-off-by: Manish Mandlik <mmandlik@google.com>
> ---
>
> net/bluetooth/hci_request.c | 17 -----------------
> 1 file changed, 17 deletions(-)
patch has been applied to bluetooth-next tree.
If you know the controller that doesn’t support this, can we blacklist that one and just disable advertising (peripheral mode) for that controller.
Regards
Marcel
next prev parent reply other threads:[~2020-03-18 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 5:40 [PATCH] Bluetooth: Do not cancel advertising when starting a scan Manish Mandlik
2020-03-18 11:26 ` Marcel Holtmann [this message]
2020-03-18 11:31 ` Emil Lenngren
2020-03-18 11:54 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF7C709-1AD3-42FF-A0C2-EF488D82F083@holtmann.org \
--to=marcel@holtmann.org \
--cc=alainm@chromium.org \
--cc=davem@davemloft.net \
--cc=dmitrygr@google.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcchou@chromium.org \
--cc=mmandlik@google.com \
--cc=netdev@vger.kernel.org \
--cc=yshavit@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).