From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] Bluetooth: a2mp: Use struct_size() helper
Date: Thu, 07 Feb 2019 20:00:42 -0800 [thread overview]
Message-ID: <4faff31066c10285bab0afdb0c1f88f6d3d1a21b.camel@perches.com> (raw)
In-Reply-To: <20190208002817.GA15338@embeddedor>
On Thu, 2019-02-07 at 18:28 -0600, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> struct boo entry[];
> };
>
> size = sizeof(struct foo) + count * sizeof(struct boo);
> instance = alloc(size, GFP_KERNEL)
>
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
>
> size = struct_size(instance, entry, count);
> instance = alloc(size, GFP_KERNEL)
>
> This code was detected with the help of Coccinelle.
[]
> diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
[]
> @@ -174,7 +174,7 @@ static int a2mp_discover_req(struct amp_mgr *mgr, struct sk_buff *skb,
> num_ctrl++;
> }
>
> - len = num_ctrl * sizeof(struct a2mp_cl) + sizeof(*rsp);
> + len = struct_size(rsp, cl, num_ctrl);
> rsp = kmalloc(len, GFP_ATOMIC);
> if (!rsp) {
> read_unlock(&hci_dev_list_lock);
At least a weakness in this code is len is u16
and struct_size is size_t so there's a size
truncation possible.
next prev parent reply other threads:[~2019-02-08 4:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 0:28 [PATCH][next] Bluetooth: a2mp: Use struct_size() helper Gustavo A. R. Silva
2019-02-08 4:00 ` Joe Perches [this message]
2019-02-08 4:07 ` Gustavo A. R. Silva
2019-02-18 13:02 ` Marcel Holtmann
2019-02-18 17:50 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4faff31066c10285bab0afdb0c1f88f6d3d1a21b.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).