From: Marcel Holtmann <marcel@holtmann.org>
To: David Summers <beagleboard@davidjohnsummers.uk>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
mark.rutland@arm.com, linux-bluetooth@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv2] Patch to add the realtek bluetooth device tree refs to the code
Date: Fri, 18 Jan 2019 11:57:17 +0100 [thread overview]
Message-ID: <510BE8B9-76BD-4A64-86C2-ACA1D50819DF@holtmann.org> (raw)
In-Reply-To: <20190103163538.6575-2-beagleboard@davidjohnsummers.uk>
Hi David,
> This patch adds the necessary device tree hooks to the realtek
> bluetooth driver for serial connections.
>
> The realtek devices that are listed btrtl.c are searched on the
> realtek web site for the version that have serial connections.
>
> Most of these devices also have wi-fi connected via sdio, that is not
> covered by the bluetooth driver - but as that interface will also be
> needed in the device tree, the hocks here have "-bluetooth" added. The
> exception to this is the rtl8761atv, which only has a serial
> bluetooth.
>
> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
> ---
> drivers/bluetooth/hci_h5.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 8eede1197cd2..2fec7ff2ce7c 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -925,6 +925,22 @@ static struct h5_vnd rtl_vnd = {
> };
> #endif
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id h5_of_match[] = {
> +#ifdef CONFIG_BT_HCIUART_RTL
> + { .compatible = "realtek,rtl8723as-bluetooth"},
> + { .compatible = "realtek,rtl8723bs-bluetooth"},
> + { .compatible = "realtek,rtl8723ds-bluetooth"},
> + { .compatible = "realtek,rtl8761atv"},
> + { .compatible = "realtek,rtl8821as-bluetooth"},
> + { .compatible = "realtek,rtl8821cs-bluetooth"},
> + { .compatible = "realtek,rtl8822bs-bluetooth"},
> +#endif
I really need an Ack from Rob on the naming here.
Regards
Marcel
next prev parent reply other threads:[~2019-01-18 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 11:55 [PATCH] bluetooth: realtek: devicetree: Add device tree description to bluetooth rtl drivers David Summers
2018-12-29 16:51 ` David Summers
2018-12-30 10:25 ` Marcel Holtmann
2019-01-03 16:35 ` [PATCHv2] Description of the realtek bluetooth device tree hooks David Summers
2019-01-03 16:35 ` [PATCHv2] Patch to add the realtek bluetooth device tree refs to the code David Summers
2019-01-18 10:57 ` Marcel Holtmann [this message]
2019-01-19 13:18 ` beagleboard
2019-01-11 16:34 ` [PATCHv2] Description of the realtek bluetooth device tree hooks Rob Herring
2019-01-12 15:00 ` David Summers
2019-01-15 19:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510BE8B9-76BD-4A64-86C2-ACA1D50819DF@holtmann.org \
--to=marcel@holtmann.org \
--cc=beagleboard@davidjohnsummers.uk \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).