From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6672AC63793 for ; Thu, 22 Jul 2021 14:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BA646101E for ; Thu, 22 Jul 2021 14:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232231AbhGVNvm convert rfc822-to-8bit (ORCPT ); Thu, 22 Jul 2021 09:51:42 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:49782 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbhGVNvk (ORCPT ); Thu, 22 Jul 2021 09:51:40 -0400 Received: from smtpclient.apple (p5b3d2eb8.dip0.t-ipconnect.de [91.61.46.184]) by mail.holtmann.org (Postfix) with ESMTPSA id 536BECECDD; Thu, 22 Jul 2021 16:32:14 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH v2 1/3] Bluetooth: hci_h5: add WAKEUP_DISABLE flag From: Marcel Holtmann In-Reply-To: <20210715225146.v2.1.I68649745bd11a83265f1e816bf34ecc82775e95a@changeid> Date: Thu, 22 Jul 2021 16:32:13 +0200 Cc: linux-bluetooth , CrosBT Upstreaming , Archie Pusaka , Abhishek Pandit-Subedi , Hilda Wu , Johan Hedberg , Luiz Augusto von Dentz , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <57AE120A-78AE-4990-8D7F-BA8D8077B610@holtmann.org> References: <20210715225146.v2.1.I68649745bd11a83265f1e816bf34ecc82775e95a@changeid> To: Archie Pusaka X-Mailer: Apple Mail (2.3654.100.0.2.22) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Archie, > Some RTL chips resets the FW on suspend, so wakeup is disabled on > those chips. This patch introduces this WAKEUP_DISABLE flag so that > chips that doesn't reset FW on suspend can leave the flag unset and > is allowed to wake the host. > > This patch also left RTL8822 WAKEUP_DISABLE flag unset, therefore > allowing it to wake the host, and preventing reprobing on resume. > > Signed-off-by: Archie Pusaka > Reviewed-by: Abhishek Pandit-Subedi > Reviewed-by: Hilda Wu > > --- > > Changes in v2: > * Remove unnecessary variable > > drivers/bluetooth/hci_h5.c | 83 +++++++++++++++++++++++++++----------- > 1 file changed, 59 insertions(+), 24 deletions(-) so the set does not apply cleanly to bluetooth-next Applying: Bluetooth: hci_h5: Add runtime suspend error: patch failed: drivers/bluetooth/hci_h5.c:11 error: drivers/bluetooth/hci_h5.c: patch does not apply And I am really close to not accepting any patches for hci_h5.c anymore. This thing turns into crazy hacking and nobody is taking my hint to redo this as clean H:5 3-Wire serdev standalone driver. Regards Marcel