Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
       [not found] <0000000000003fd4ab058e46951f@google.com>
@ 2019-07-23  7:29 ` Dmitry Vyukov
  2019-07-25  9:44   ` Marcel Holtmann
  0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Vyukov @ 2019-07-23  7:29 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, linux-bluetooth
  Cc: LKML, syzkaller-bugs, syzbot

On Mon, Jul 22, 2019 at 5:18 PM syzbot
<syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
> git tree:       linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000

+drivers/bluetooth/hci_h5.c maintainers

> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
>
> ==================================================================
> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
> /drivers/bluetooth/hci_h5.c:438
> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
>
> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
> Google 01/01/2011
> Call Trace:
>   __dump_stack /lib/dump_stack.c:77 [inline]
>   dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
>   print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
>   __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
>   kasan_report+0x12/0x17 /mm/kasan/common.c:612
>   __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
>   h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
>   h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>   hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>   tiocsti /drivers/tty/tty_io.c:2197 [inline]
>   tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
>   vfs_ioctl /fs/ioctl.c:46 [inline]
>   file_ioctl /fs/ioctl.c:509 [inline]
>   do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
>   ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
>   __do_sys_ioctl /fs/ioctl.c:720 [inline]
>   __se_sys_ioctl /fs/ioctl.c:718 [inline]
>   __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
>   do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
>   entry_SYSCALL_64_after_hwframe+0x49/0xbe
> RIP: 0033:0x459819
> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff
>
> Allocated by task 9200:
>   save_stack+0x23/0x90 /mm/kasan/common.c:69
>   set_track /mm/kasan/common.c:77 [inline]
>   __kasan_kmalloc /mm/kasan/common.c:487 [inline]
>   __kasan_kmalloc.constprop.0+0xcf/0xe0 /mm/kasan/common.c:460
>   kasan_kmalloc+0x9/0x10 /mm/kasan/common.c:501
>   __do_kmalloc_node /mm/slab.c:3615 [inline]
>   __kmalloc_node_track_caller+0x4e/0x70 /mm/slab.c:3629
>   __kmalloc_reserve.isra.0+0x40/0xf0 /net/core/skbuff.c:141
>   __alloc_skb+0x10b/0x5e0 /net/core/skbuff.c:209
>   alloc_skb /./include/linux/skbuff.h:1055 [inline]
>   bt_skb_alloc /./include/net/bluetooth/bluetooth.h:339 [inline]
>   h5_rx_pkt_start+0xce/0x270 /drivers/bluetooth/hci_h5.c:474
>   h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>   hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>   tty_ldisc_receive_buf+0x15f/0x1c0 /drivers/tty/tty_buffer.c:465
>   tty_port_default_receive_buf+0x7d/0xb0 /drivers/tty/tty_port.c:38
>   receive_buf /drivers/tty/tty_buffer.c:481 [inline]
>   flush_to_ldisc+0x222/0x390 /drivers/tty/tty_buffer.c:533
>   process_one_work+0x9af/0x1740 /kernel/workqueue.c:2269
>   worker_thread+0x98/0xe40 /kernel/workqueue.c:2415
>   kthread+0x361/0x430 /kernel/kthread.c:255
>   ret_from_fork+0x24/0x30 /arch/x86/entry/entry_64.S:352
>
> Freed by task 9200:
>   save_stack+0x23/0x90 /mm/kasan/common.c:69
>   set_track /mm/kasan/common.c:77 [inline]
>   __kasan_slab_free+0x102/0x150 /mm/kasan/common.c:449
>   kasan_slab_free+0xe/0x10 /mm/kasan/common.c:457
>   __cache_free /mm/slab.c:3425 [inline]
>   kfree+0x10a/0x2c0 /mm/slab.c:3756
>   skb_free_head+0x93/0xb0 /net/core/skbuff.c:591
>   skb_release_data+0x42d/0x7c0 /net/core/skbuff.c:611
>   skb_release_all+0x4d/0x60 /net/core/skbuff.c:665
>   __kfree_skb /net/core/skbuff.c:679 [inline]
>   kfree_skb /net/core/skbuff.c:697 [inline]
>   kfree_skb+0x101/0x3c0 /net/core/skbuff.c:691
>   h5_reset_rx+0x4c/0x120 /drivers/bluetooth/hci_h5.c:530
>   h5_rx_3wire_hdr+0x2f5/0x3c0 /drivers/bluetooth/hci_h5.c:440
>   h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>   hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>   tty_ldisc_receive_buf+0x15f/0x1c0 /drivers/tty/tty_buffer.c:465
>   tty_port_default_receive_buf+0x7d/0xb0 /drivers/tty/tty_port.c:38
>   receive_buf /drivers/tty/tty_buffer.c:481 [inline]
>   flush_to_ldisc+0x222/0x390 /drivers/tty/tty_buffer.c:533
>   process_one_work+0x9af/0x1740 /kernel/workqueue.c:2269
>   worker_thread+0x98/0xe40 /kernel/workqueue.c:2415
>   kthread+0x361/0x430 /kernel/kthread.c:255
>   ret_from_fork+0x24/0x30 /arch/x86/entry/entry_64.S:352
>
> The buggy address belongs to the object at ffff8880a161d1c0
>   which belongs to the cache kmalloc-8k of size 8192
> The buggy address is located 8 bytes inside of
>   8192-byte region [ffff8880a161d1c0, ffff8880a161f1c0)
> The buggy address belongs to the page:
> page:ffffea0002858700 refcount:1 mapcount:0 mapping:ffff8880aa4021c0
> index:0x0 compound_mapcount: 0
> flags: 0x1fffc0000010200(slab|head)
> raw: 01fffc0000010200 ffffea0002850508 ffffea000262ed08 ffff8880aa4021c0
> raw: 0000000000000000 ffff8880a161d1c0 0000000100000001 0000000000000000
> page dumped because: kasan: bad access detected
>
> Memory state around the buggy address:
>   ffff8880a161d080: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>   ffff8880a161d100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
> > ffff8880a161d180: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
>                                                ^
>   ffff8880a161d200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>   ffff8880a161d280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> ==================================================================
>
>
> ---
> This bug is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
>
> syzbot will keep track of this bug report. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> syzbot can test patches for this bug, for details see:
> https://goo.gl/tpsmEJ#testing-patches
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/0000000000003fd4ab058e46951f%40google.com.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
  2019-07-23  7:29 ` KASAN: use-after-free Read in h5_rx_3wire_hdr Dmitry Vyukov
@ 2019-07-25  9:44   ` Marcel Holtmann
  2019-07-25  9:51     ` Dmitry Vyukov
  0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2019-07-25  9:44 UTC (permalink / raw)
  To: Dmitry Vyukov
  Cc: Johan Hedberg, linux-bluetooth, LKML, syzkaller-bugs, syzbot

Hi Dmitry,

>> syzbot found the following crash on:
>> 
>> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
>> git tree:       linux-next
>> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
>> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
>> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000
> 
> +drivers/bluetooth/hci_h5.c maintainers
> 
>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
>> 
>> ==================================================================
>> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
>> /drivers/bluetooth/hci_h5.c:438
>> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
>> 
>> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>> Google 01/01/2011
>> Call Trace:
>>  __dump_stack /lib/dump_stack.c:77 [inline]
>>  dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
>>  print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
>>  __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
>>  kasan_report+0x12/0x17 /mm/kasan/common.c:612
>>  __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
>>  h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
>>  h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>>  hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>>  tiocsti /drivers/tty/tty_io.c:2197 [inline]
>>  tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
>>  vfs_ioctl /fs/ioctl.c:46 [inline]
>>  file_ioctl /fs/ioctl.c:509 [inline]
>>  do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
>>  ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
>>  __do_sys_ioctl /fs/ioctl.c:720 [inline]
>>  __se_sys_ioctl /fs/ioctl.c:718 [inline]
>>  __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
>>  do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
>>  entry_SYSCALL_64_after_hwframe+0x49/0xbe
>> RIP: 0033:0x459819
>> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
>> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
>> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
>> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
>> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
>> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
>> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
>> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff

Is this happening on specific hardware?

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
  2019-07-25  9:44   ` Marcel Holtmann
@ 2019-07-25  9:51     ` Dmitry Vyukov
  2019-07-25  9:53       ` Marcel Holtmann
  0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Vyukov @ 2019-07-25  9:51 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Johan Hedberg, linux-bluetooth, LKML, syzkaller-bugs, syzbot

On Thu, Jul 25, 2019 at 11:44 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Dmitry,
>
> >> syzbot found the following crash on:
> >>
> >> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
> >> git tree:       linux-next
> >> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
> >> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
> >> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
> >> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> >> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000
> >
> > +drivers/bluetooth/hci_h5.c maintainers
> >
> >> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> >> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
> >>
> >> ==================================================================
> >> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
> >> /drivers/bluetooth/hci_h5.c:438
> >> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
> >>
> >> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
> >> Google 01/01/2011
> >> Call Trace:
> >>  __dump_stack /lib/dump_stack.c:77 [inline]
> >>  dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
> >>  print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
> >>  __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
> >>  kasan_report+0x12/0x17 /mm/kasan/common.c:612
> >>  __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
> >>  h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
> >>  h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
> >>  hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
> >>  tiocsti /drivers/tty/tty_io.c:2197 [inline]
> >>  tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
> >>  vfs_ioctl /fs/ioctl.c:46 [inline]
> >>  file_ioctl /fs/ioctl.c:509 [inline]
> >>  do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
> >>  ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
> >>  __do_sys_ioctl /fs/ioctl.c:720 [inline]
> >>  __se_sys_ioctl /fs/ioctl.c:718 [inline]
> >>  __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
> >>  do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
> >>  entry_SYSCALL_64_after_hwframe+0x49/0xbe
> >> RIP: 0033:0x459819
> >> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
> >> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
> >> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
> >> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> >> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
> >> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
> >> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
> >> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
> >> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff
>
> Is this happening on specific hardware?

> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
  2019-07-25  9:51     ` Dmitry Vyukov
@ 2019-07-25  9:53       ` Marcel Holtmann
  2019-07-25 10:07         ` Dmitry Vyukov
  0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2019-07-25  9:53 UTC (permalink / raw)
  To: Dmitry Vyukov
  Cc: Johan Hedberg, linux-bluetooth, LKML, syzkaller-bugs, syzbot

Hi Dmitry,

>>>> syzbot found the following crash on:
>>>> 
>>>> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
>>>> git tree:       linux-next
>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
>>>> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
>>>> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
>>>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000
>>> 
>>> +drivers/bluetooth/hci_h5.c maintainers
>>> 
>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>>>> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
>>>> 
>>>> ==================================================================
>>>> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
>>>> /drivers/bluetooth/hci_h5.c:438
>>>> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
>>>> 
>>>> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
>>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>>>> Google 01/01/2011
>>>> Call Trace:
>>>> __dump_stack /lib/dump_stack.c:77 [inline]
>>>> dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
>>>> print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
>>>> __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
>>>> kasan_report+0x12/0x17 /mm/kasan/common.c:612
>>>> __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
>>>> h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
>>>> h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>>>> hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>>>> tiocsti /drivers/tty/tty_io.c:2197 [inline]
>>>> tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
>>>> vfs_ioctl /fs/ioctl.c:46 [inline]
>>>> file_ioctl /fs/ioctl.c:509 [inline]
>>>> do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
>>>> ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
>>>> __do_sys_ioctl /fs/ioctl.c:720 [inline]
>>>> __se_sys_ioctl /fs/ioctl.c:718 [inline]
>>>> __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
>>>> do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe
>>>> RIP: 0033:0x459819
>>>> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
>>>> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
>>>> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
>>>> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
>>>> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
>>>> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
>>>> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
>>>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
>>>> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff
>> 
>> Is this happening on specific hardware?
> 
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS

funny ;)

I meant the Bluetooth chip on this machine.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
  2019-07-25  9:53       ` Marcel Holtmann
@ 2019-07-25 10:07         ` Dmitry Vyukov
  2019-07-25 13:04           ` Marcel Holtmann
  0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Vyukov @ 2019-07-25 10:07 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Johan Hedberg, linux-bluetooth, LKML, syzkaller-bugs, syzbot

On Thu, Jul 25, 2019 at 11:53 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Dmitry,
>
> >>>> syzbot found the following crash on:
> >>>>
> >>>> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
> >>>> git tree:       linux-next
> >>>> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
> >>>> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
> >>>> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
> >>>> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> >>>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000
> >>>
> >>> +drivers/bluetooth/hci_h5.c maintainers
> >>>
> >>>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> >>>> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
> >>>>
> >>>> ==================================================================
> >>>> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
> >>>> /drivers/bluetooth/hci_h5.c:438
> >>>> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
> >>>>
> >>>> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
> >>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
> >>>> Google 01/01/2011
> >>>> Call Trace:
> >>>> __dump_stack /lib/dump_stack.c:77 [inline]
> >>>> dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
> >>>> print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
> >>>> __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
> >>>> kasan_report+0x12/0x17 /mm/kasan/common.c:612
> >>>> __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
> >>>> h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
> >>>> h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
> >>>> hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
> >>>> tiocsti /drivers/tty/tty_io.c:2197 [inline]
> >>>> tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
> >>>> vfs_ioctl /fs/ioctl.c:46 [inline]
> >>>> file_ioctl /fs/ioctl.c:509 [inline]
> >>>> do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
> >>>> ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
> >>>> __do_sys_ioctl /fs/ioctl.c:720 [inline]
> >>>> __se_sys_ioctl /fs/ioctl.c:718 [inline]
> >>>> __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
> >>>> do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
> >>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe
> >>>> RIP: 0033:0x459819
> >>>> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
> >>>> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
> >>>> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
> >>>> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> >>>> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
> >>>> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
> >>>> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
> >>>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
> >>>> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff
> >>
> >> Is this happening on specific hardware?
> >
> >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>
> funny ;)
>
> I meant the Bluetooth chip on this machine.

I don't think there are any Bluetooth chips exposed in GCE VMs. I
would expect that this bug does not require any hardware to trigger.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: KASAN: use-after-free Read in h5_rx_3wire_hdr
  2019-07-25 10:07         ` Dmitry Vyukov
@ 2019-07-25 13:04           ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2019-07-25 13:04 UTC (permalink / raw)
  To: Dmitry Vyukov
  Cc: Johan Hedberg, linux-bluetooth, LKML, syzkaller-bugs, syzbot

Hi Dmitry,

>>>>>> syzbot found the following crash on:
>>>>>> 
>>>>>> HEAD commit:    6d21a41b Add linux-next specific files for 20190718
>>>>>> git tree:       linux-next
>>>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=1377958fa00000
>>>>>> kernel config:  https://syzkaller.appspot.com/x/.config?x=3430a151e1452331
>>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=0abbda0523882250a97a
>>>>>> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
>>>>>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=113e2bb7a00000
>>>>> 
>>>>> +drivers/bluetooth/hci_h5.c maintainers
>>>>> 
>>>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>>>>>> Reported-by: syzbot+0abbda0523882250a97a@syzkaller.appspotmail.com
>>>>>> 
>>>>>> ==================================================================
>>>>>> BUG: KASAN: use-after-free in h5_rx_3wire_hdr+0x35d/0x3c0
>>>>>> /drivers/bluetooth/hci_h5.c:438
>>>>>> Read of size 1 at addr ffff8880a161d1c8 by task syz-executor.4/12040
>>>>>> 
>>>>>> CPU: 1 PID: 12040 Comm: syz-executor.4 Not tainted 5.2.0-next-20190718 #41
>>>>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>>>>>> Google 01/01/2011
>>>>>> Call Trace:
>>>>>> __dump_stack /lib/dump_stack.c:77 [inline]
>>>>>> dump_stack+0x172/0x1f0 /lib/dump_stack.c:113
>>>>>> print_address_description.cold+0xd4/0x306 /mm/kasan/report.c:351
>>>>>> __kasan_report.cold+0x1b/0x36 /mm/kasan/report.c:482
>>>>>> kasan_report+0x12/0x17 /mm/kasan/common.c:612
>>>>>> __asan_report_load1_noabort+0x14/0x20 /mm/kasan/generic_report.c:129
>>>>>> h5_rx_3wire_hdr+0x35d/0x3c0 /drivers/bluetooth/hci_h5.c:438
>>>>>> h5_recv+0x32f/0x500 /drivers/bluetooth/hci_h5.c:563
>>>>>> hci_uart_tty_receive+0x279/0x790 /drivers/bluetooth/hci_ldisc.c:600
>>>>>> tiocsti /drivers/tty/tty_io.c:2197 [inline]
>>>>>> tty_ioctl+0x949/0x14f0 /drivers/tty/tty_io.c:2573
>>>>>> vfs_ioctl /fs/ioctl.c:46 [inline]
>>>>>> file_ioctl /fs/ioctl.c:509 [inline]
>>>>>> do_vfs_ioctl+0xdb6/0x13e0 /fs/ioctl.c:696
>>>>>> ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713
>>>>>> __do_sys_ioctl /fs/ioctl.c:720 [inline]
>>>>>> __se_sys_ioctl /fs/ioctl.c:718 [inline]
>>>>>> __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718
>>>>>> do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296
>>>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe
>>>>>> RIP: 0033:0x459819
>>>>>> Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
>>>>>> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
>>>>>> ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
>>>>>> RSP: 002b:00007f7a3b459c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
>>>>>> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819
>>>>>> RDX: 0000000020000080 RSI: 0000000000005412 RDI: 0000000000000003
>>>>>> RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
>>>>>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a3b45a6d4
>>>>>> R13: 00000000004c408a R14: 00000000004d7ff0 R15: 00000000ffffffff
>>>> 
>>>> Is this happening on specific hardware?
>>> 
>>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
>> 
>> funny ;)
>> 
>> I meant the Bluetooth chip on this machine.
> 
> I don't think there are any Bluetooth chips exposed in GCE VMs. I
> would expect that this bug does not require any hardware to trigger.

then this might be also the same bug as the other missing drivers->ops checking. See https://lore.kernel.org/linux-bluetooth/2E234F47-724D-4CFB-93B5-48E5BDA6F230@holtmann.org/ for a proposed patch. However I have the feeling that hci_h5.c needs to be added to this as well.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <0000000000003fd4ab058e46951f@google.com>
2019-07-23  7:29 ` KASAN: use-after-free Read in h5_rx_3wire_hdr Dmitry Vyukov
2019-07-25  9:44   ` Marcel Holtmann
2019-07-25  9:51     ` Dmitry Vyukov
2019-07-25  9:53       ` Marcel Holtmann
2019-07-25 10:07         ` Dmitry Vyukov
2019-07-25 13:04           ` Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox