linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com
Subject: RE: [BlueZ] log: Make error and warn log file and function information
Date: Wed, 29 Apr 2020 14:35:25 -0700 (PDT)	[thread overview]
Message-ID: <5ea9f31d.1c69fb81.3f794.3102@mx.google.com> (raw)
In-Reply-To: <20200429210419.1569840-1-luiz.dentz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkpatch Failed

Patch Title:
[BlueZ] log: Make error and warn log file and function information

Output:
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#65: FILE: src/log.h:73:
+	btd_error(0xffff, "%s:%s() " fmt, __FILE__, __func__ , ## arg)
 	                                                     ^

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#67: FILE: src/log.h:75:
+	btd_warn(0xffff, "%s:%s() " fmt, __FILE__, __func__ , ## arg)
 	                                                    ^

- total: 2 errors, 0 warnings, 47 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



For more details about BlueZ coding style guide, please find it
in doc/coding-style.txt

---
Regards,
Linux Bluetooth

      reply	other threads:[~2020-04-29 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 21:04 [PATCH BlueZ] log: Make error and warn log file and function information Luiz Augusto von Dentz
2020-04-29 21:35 ` bluez.test.bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ea9f31d.1c69fb81.3f794.3102@mx.google.com \
    --to=bluez.test.bot@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).