From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, abhishekpandit@chromium.org
Subject: RE: [BlueZ,v5,2/6] monitor: Decode device flags mgmt ops and event
Date: Mon, 22 Jun 2020 16:47:33 -0700 (PDT) [thread overview]
Message-ID: <5ef14315.1c69fb81.384d0.5dd8@mx.google.com> (raw)
In-Reply-To: <20200622164003.BlueZ.v5.2.Ieac700ddea68a19e8c3dc53528f686482076a77a@changeid>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkpatch Failed
Outputs:
WARNING:LINE_SPACING: Missing a blank line after declarations
#68: FILE: monitor/packet.c:13122:
+ uint8_t type = get_u8(data + 6);
+ mgmt_print_address(data, type);
WARNING:LINE_SPACING: Missing a blank line after declarations
#94: FILE: monitor/packet.c:13148:
+ uint8_t type = get_u8(data + 6);
+ mgmt_print_address(data, type);
- total: 0 errors, 2 warnings, 98 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2020-06-22 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 23:40 [BlueZ PATCH v5 0/6] device: Allow devices to be marked as wake capable Abhishek Pandit-Subedi
2020-06-22 23:40 ` [BlueZ PATCH v5 1/6] mgmt: Add mgmt op and events for device flags Abhishek Pandit-Subedi
2020-06-22 23:49 ` device: Allow devices to be marked as wake capable bluez.test.bot
2020-06-22 23:40 ` [BlueZ PATCH v5 2/6] monitor: Decode device flags mgmt ops and event Abhishek Pandit-Subedi
2020-06-22 23:47 ` bluez.test.bot [this message]
2020-06-22 23:40 ` [BlueZ PATCH v5 3/6] device: Support marking a device with wake allowed Abhishek Pandit-Subedi
2020-06-22 23:47 ` [BlueZ,v5,3/6] " bluez.test.bot
2020-06-23 0:10 ` [BlueZ PATCH v5 3/6] " Luiz Augusto von Dentz
2020-06-24 3:53 ` Abhishek Pandit-Subedi
2020-06-22 23:40 ` [BlueZ PATCH v5 4/6] client: Display wake allowed property with info Abhishek Pandit-Subedi
2020-06-22 23:40 ` [BlueZ PATCH v5 5/6] doc/device-api: Add WakeAllowed Abhishek Pandit-Subedi
2020-06-22 23:40 ` [BlueZ PATCH v5 6/6] input: Make HID devices support wake Abhishek Pandit-Subedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ef14315.1c69fb81.384d0.5dd8@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=abhishekpandit@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).