From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, howardchung@google.com
Subject: RE: [Bluez,v2] a2dp: Fix crash in channel_free while waiting cmd resp
Date: Mon, 12 Jul 2021 21:39:42 -0700 (PDT) [thread overview]
Message-ID: <60ed190e.1c69fb81.bda6f.ad2a@mx.google.com> (raw)
In-Reply-To: <20210713115042.Bluez.v2.1.Id7aa1152377161d17b442bf258773d9b6c624ca3@changeid>
[-- Attachment #1: Type: text/plain, Size: 32387 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=514437
---Test result---
Test Summary:
CheckPatch PASS 0.46 seconds
GitLint FAIL 0.12 seconds
Prep - Setup ELL PASS 42.89 seconds
Build - Prep PASS 0.15 seconds
Build - Configure PASS 7.46 seconds
Build - Make FAIL 143.49 seconds
Make Check FAIL 0.49 seconds
Make Distcheck FAIL 129.00 seconds
Build w/ext ELL - Configure PASS 7.46 seconds
Build w/ext ELL - Make FAIL 131.89 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
a2dp: Fix crash in channel_free while waiting cmd resp
14: B3 Line contains hard tab characters (\t): "0x000059f01943e688 (bluetoothd -avdtp.c:3690)"
16: B3 Line contains hard tab characters (\t): "0x000059f01943928a (bluetoothd -a2dp.c:3069)"
18: B3 Line contains hard tab characters (\t): "0x000059f0194377fa (bluetoothd -sink.c:324)"
20: B3 Line contains hard tab characters (\t): "0x000059f01948715a (bluetoothd -service.c:177)"
22: B3 Line contains hard tab characters (\t): "0x000059f01948d77c (bluetoothd -device.c:5346)"
24: B3 Line contains hard tab characters (\t): "0x000059f019476d14 (bluetoothd -adapter.c:7202)"
26: B3 Line contains hard tab characters (\t): "0x000059f019476c3e (bluetoothd -adapter.c:10827)"
28: B3 Line contains hard tab characters (\t): "0x000059f01949d8d7 (bluetoothd -main.c:1114) main"
29: B3 Line contains hard tab characters (\t): "0x0000787b36185d74 (libc.so.6 -libc-start.c:308)"
31: B3 Line contains hard tab characters (\t): "0x000059f019433e39 (bluetoothd + 0x00026e39) _start"
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:420:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
420 | cb->select_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:420:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:421:6: error: passing argument 3 of ‘cb->select_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:421:6: note: expected ‘GSList *’ {aka ‘struct _GSList *’} but argument is of type ‘int’
profiles/audio/a2dp.c:421:32: error: passing argument 4 of ‘cb->select_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:421:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:420:4: error: too few arguments to function ‘cb->select_cb’
420 | cb->select_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:423:32: error: passing argument 2 of ‘cb->suspend_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
423 | cb->suspend_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:423:32: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:424:6: error: passing argument 3 of ‘cb->suspend_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
424 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:424:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:423:4: error: too many arguments to function ‘cb->suspend_cb’
423 | cb->suspend_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:426:31: error: passing argument 2 of ‘cb->resume_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
426 | cb->resume_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:426:31: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:427:6: error: passing argument 3 of ‘cb->resume_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
427 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:427:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:426:4: error: too many arguments to function ‘cb->resume_cb’
426 | cb->resume_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:429:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
429 | cb->config_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:429:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:430:6: error: passing argument 3 of ‘cb->config_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:430:6: note: expected ‘struct avdtp_stream *’ but argument is of type ‘int’
profiles/audio/a2dp.c:430:32: error: passing argument 4 of ‘cb->config_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:430:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:429:4: error: too few arguments to function ‘cb->config_cb’
429 | cb->config_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c: At top level:
profiles/audio/a2dp.c:438:13: error: redefinition of ‘finalize_all’
438 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c:407:13: note: previous definition of ‘finalize_all’ was here
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:452:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
452 | cb->select_cb(s->session, s->seps, s->caps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:452:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:461:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
461 | cb->config_cb(s->session, s->seps, stream,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:461:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c: In function ‘channel_free’:
profiles/audio/a2dp.c:1608:42: error: passing argument 3 of ‘finalize_setup_errno’ from incompatible pointer type [-Werror=incompatible-pointer-types]
1608 | finalize_setup_errno(setup, -ENOTCONN, finalize_all, NULL);
| ^~~~~~~~~~~~
| |
| void (*)(struct a2dp_setup *)
profiles/audio/a2dp.c:262:18: note: expected ‘GSourceFunc’ {aka ‘int (*)(void *)’} but argument is of type ‘void (*)(struct a2dp_setup *)’
262 | GSourceFunc cb1, ...)
| ~~~~~~~~~~~~^~~
At top level:
profiles/audio/a2dp.c:407:13: error: ‘finalize_all’ defined but not used [-Werror=unused-function]
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8531: profiles/audio/bluetoothd-a2dp.o] Error 1
make: *** [Makefile:4134: all] Error 2
##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:420:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
420 | cb->select_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:420:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:421:6: error: passing argument 3 of ‘cb->select_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:421:6: note: expected ‘GSList *’ {aka ‘struct _GSList *’} but argument is of type ‘int’
profiles/audio/a2dp.c:421:32: error: passing argument 4 of ‘cb->select_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:421:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:420:4: error: too few arguments to function ‘cb->select_cb’
420 | cb->select_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:423:32: error: passing argument 2 of ‘cb->suspend_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
423 | cb->suspend_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:423:32: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:424:6: error: passing argument 3 of ‘cb->suspend_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
424 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:424:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:423:4: error: too many arguments to function ‘cb->suspend_cb’
423 | cb->suspend_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:426:31: error: passing argument 2 of ‘cb->resume_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
426 | cb->resume_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:426:31: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:427:6: error: passing argument 3 of ‘cb->resume_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
427 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:427:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:426:4: error: too many arguments to function ‘cb->resume_cb’
426 | cb->resume_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:429:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
429 | cb->config_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:429:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:430:6: error: passing argument 3 of ‘cb->config_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:430:6: note: expected ‘struct avdtp_stream *’ but argument is of type ‘int’
profiles/audio/a2dp.c:430:32: error: passing argument 4 of ‘cb->config_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:430:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:429:4: error: too few arguments to function ‘cb->config_cb’
429 | cb->config_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c: At top level:
profiles/audio/a2dp.c:438:13: error: redefinition of ‘finalize_all’
438 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c:407:13: note: previous definition of ‘finalize_all’ was here
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:452:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
452 | cb->select_cb(s->session, s->seps, s->caps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:452:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:461:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
461 | cb->config_cb(s->session, s->seps, stream,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:461:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c: In function ‘channel_free’:
profiles/audio/a2dp.c:1608:42: error: passing argument 3 of ‘finalize_setup_errno’ from incompatible pointer type [-Werror=incompatible-pointer-types]
1608 | finalize_setup_errno(setup, -ENOTCONN, finalize_all, NULL);
| ^~~~~~~~~~~~
| |
| void (*)(struct a2dp_setup *)
profiles/audio/a2dp.c:262:18: note: expected ‘GSourceFunc’ {aka ‘int (*)(void *)’} but argument is of type ‘void (*)(struct a2dp_setup *)’
262 | GSourceFunc cb1, ...)
| ~~~~~~~~~~~~^~~
At top level:
profiles/audio/a2dp.c:407:13: error: ‘finalize_all’ defined but not used [-Werror=unused-function]
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8531: profiles/audio/bluetoothd-a2dp.o] Error 1
make: *** [Makefile:10406: check] Error 2
##############################
Test: Make Distcheck - FAIL
Desc: Run distcheck to check the distribution
Output:
../../profiles/audio/a2dp.c: In function ‘finalize_all’:
../../profiles/audio/a2dp.c:420:31: warning: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Wincompatible-pointer-types]
420 | cb->select_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:420:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c:421:6: warning: passing argument 3 of ‘cb->select_cb’ makes pointer from integer without a cast [-Wint-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
../../profiles/audio/a2dp.c:421:6: note: expected ‘GSList *’ {aka ‘struct _GSList *’} but argument is of type ‘int’
../../profiles/audio/a2dp.c:421:32: warning: passing argument 4 of ‘cb->select_cb’ makes integer from pointer without a cast [-Wint-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
../../profiles/audio/a2dp.c:421:32: note: expected ‘int’ but argument is of type ‘void *’
../../profiles/audio/a2dp.c:420:4: error: too few arguments to function ‘cb->select_cb’
420 | cb->select_cb(s->session, s->seps,
| ^~
../../profiles/audio/a2dp.c:423:32: warning: passing argument 2 of ‘cb->suspend_cb’ makes integer from pointer without a cast [-Wint-conversion]
423 | cb->suspend_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:423:32: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c:424:6: warning: passing argument 3 of ‘cb->suspend_cb’ makes pointer from integer without a cast [-Wint-conversion]
424 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
../../profiles/audio/a2dp.c:424:6: note: expected ‘void *’ but argument is of type ‘int’
../../profiles/audio/a2dp.c:423:4: error: too many arguments to function ‘cb->suspend_cb’
423 | cb->suspend_cb(s->session, s->seps,
| ^~
../../profiles/audio/a2dp.c:426:31: warning: passing argument 2 of ‘cb->resume_cb’ makes integer from pointer without a cast [-Wint-conversion]
426 | cb->resume_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:426:31: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c:427:6: warning: passing argument 3 of ‘cb->resume_cb’ makes pointer from integer without a cast [-Wint-conversion]
427 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
../../profiles/audio/a2dp.c:427:6: note: expected ‘void *’ but argument is of type ‘int’
../../profiles/audio/a2dp.c:426:4: error: too many arguments to function ‘cb->resume_cb’
426 | cb->resume_cb(s->session, s->seps,
| ^~
../../profiles/audio/a2dp.c:429:31: warning: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Wincompatible-pointer-types]
429 | cb->config_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:429:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c:430:6: warning: passing argument 3 of ‘cb->config_cb’ makes pointer from integer without a cast [-Wint-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
../../profiles/audio/a2dp.c:430:6: note: expected ‘struct avdtp_stream *’ but argument is of type ‘int’
../../profiles/audio/a2dp.c:430:32: warning: passing argument 4 of ‘cb->config_cb’ makes integer from pointer without a cast [-Wint-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
../../profiles/audio/a2dp.c:430:32: note: expected ‘int’ but argument is of type ‘void *’
../../profiles/audio/a2dp.c:429:4: error: too few arguments to function ‘cb->config_cb’
429 | cb->config_cb(s->session, s->seps,
| ^~
../../profiles/audio/a2dp.c: At top level:
../../profiles/audio/a2dp.c:438:13: error: redefinition of ‘finalize_all’
438 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
../../profiles/audio/a2dp.c:407:13: note: previous definition of ‘finalize_all’ was here
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
../../profiles/audio/a2dp.c: In function ‘finalize_all’:
../../profiles/audio/a2dp.c:452:31: warning: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Wincompatible-pointer-types]
452 | cb->select_cb(s->session, s->seps, s->caps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:452:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c:461:31: warning: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Wincompatible-pointer-types]
461 | cb->config_cb(s->session, s->seps, stream,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
../../profiles/audio/a2dp.c:461:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
../../profiles/audio/a2dp.c: In function ‘channel_free’:
../../profiles/audio/a2dp.c:1608:42: warning: passing argument 3 of ‘finalize_setup_errno’ from incompatible pointer type [-Wincompatible-pointer-types]
1608 | finalize_setup_errno(setup, -ENOTCONN, finalize_all, NULL);
| ^~~~~~~~~~~~
| |
| void (*)(struct a2dp_setup *)
../../profiles/audio/a2dp.c:262:18: note: expected ‘GSourceFunc’ {aka ‘int (*)(void *)’} but argument is of type ‘void (*)(struct a2dp_setup *)’
262 | GSourceFunc cb1, ...)
| ~~~~~~~~~~~~^~~
make[2]: *** [Makefile:8531: profiles/audio/bluetoothd-a2dp.o] Error 1
make[1]: *** [Makefile:4134: all] Error 2
make: *** [Makefile:10327: distcheck] Error 1
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:420:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
420 | cb->select_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:420:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:421:6: error: passing argument 3 of ‘cb->select_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:421:6: note: expected ‘GSList *’ {aka ‘struct _GSList *’} but argument is of type ‘int’
profiles/audio/a2dp.c:421:32: error: passing argument 4 of ‘cb->select_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
421 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:421:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:420:4: error: too few arguments to function ‘cb->select_cb’
420 | cb->select_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:423:32: error: passing argument 2 of ‘cb->suspend_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
423 | cb->suspend_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:423:32: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:424:6: error: passing argument 3 of ‘cb->suspend_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
424 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:424:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:423:4: error: too many arguments to function ‘cb->suspend_cb’
423 | cb->suspend_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:426:31: error: passing argument 2 of ‘cb->resume_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
426 | cb->resume_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:426:31: note: expected ‘int’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:427:6: error: passing argument 3 of ‘cb->resume_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
427 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:427:6: note: expected ‘void *’ but argument is of type ‘int’
profiles/audio/a2dp.c:426:4: error: too many arguments to function ‘cb->resume_cb’
426 | cb->resume_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c:429:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
429 | cb->config_cb(s->session, s->seps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:429:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:430:6: error: passing argument 3 of ‘cb->config_cb’ makes pointer from integer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
profiles/audio/a2dp.c:430:6: note: expected ‘struct avdtp_stream *’ but argument is of type ‘int’
profiles/audio/a2dp.c:430:32: error: passing argument 4 of ‘cb->config_cb’ makes integer from pointer without a cast [-Werror=int-conversion]
430 | error_to_errno(s->err), cb->user_data);
| ~~^~~~~~~~~~~
| |
| void *
profiles/audio/a2dp.c:430:32: note: expected ‘int’ but argument is of type ‘void *’
profiles/audio/a2dp.c:429:4: error: too few arguments to function ‘cb->config_cb’
429 | cb->config_cb(s->session, s->seps,
| ^~
profiles/audio/a2dp.c: At top level:
profiles/audio/a2dp.c:438:13: error: redefinition of ‘finalize_all’
438 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c:407:13: note: previous definition of ‘finalize_all’ was here
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
profiles/audio/a2dp.c: In function ‘finalize_all’:
profiles/audio/a2dp.c:452:31: error: passing argument 2 of ‘cb->select_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
452 | cb->select_cb(s->session, s->seps, s->caps,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:452:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c:461:31: error: passing argument 2 of ‘cb->config_cb’ from incompatible pointer type [-Werror=incompatible-pointer-types]
461 | cb->config_cb(s->session, s->seps, stream,
| ~^~~~~~
| |
| GSList * {aka struct _GSList *}
profiles/audio/a2dp.c:461:31: note: expected ‘struct a2dp_sep *’ but argument is of type ‘GSList *’ {aka ‘struct _GSList *’}
profiles/audio/a2dp.c: In function ‘channel_free’:
profiles/audio/a2dp.c:1608:42: error: passing argument 3 of ‘finalize_setup_errno’ from incompatible pointer type [-Werror=incompatible-pointer-types]
1608 | finalize_setup_errno(setup, -ENOTCONN, finalize_all, NULL);
| ^~~~~~~~~~~~
| |
| void (*)(struct a2dp_setup *)
profiles/audio/a2dp.c:262:18: note: expected ‘GSourceFunc’ {aka ‘int (*)(void *)’} but argument is of type ‘void (*)(struct a2dp_setup *)’
262 | GSourceFunc cb1, ...)
| ~~~~~~~~~~~~^~~
At top level:
profiles/audio/a2dp.c:407:13: error: ‘finalize_all’ defined but not used [-Werror=unused-function]
407 | static void finalize_all(struct a2dp_setup *s)
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8531: profiles/audio/bluetoothd-a2dp.o] Error 1
make: *** [Makefile:4134: all] Error 2
---
Regards,
Linux Bluetooth
prev parent reply other threads:[~2021-07-13 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 3:51 [Bluez PATCH v2] a2dp: Fix crash in channel_free while waiting cmd resp Howard Chung
2021-07-13 4:39 ` bluez.test.bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ed190e.1c69fb81.bda6f.ad2a@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).