linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bluez:fix btmon tools “Allow slave” to "Central Or Peripheral"                                                                                                                       #431 [hci0] 99.922927
@ 2021-07-23  2:03 wangyouwan
  2021-07-23  2:29 ` bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: wangyouwan @ 2021-07-23  2:03 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: wangyouwan

spec in v5.3
8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a Peripheral
when joining an existing piconet, since by definition the paging device is
initially Central of a piconet involving the pager (Central) and the paged
(Peripheral) device.
• A role switch is necessary in order for a Peripheral in an existing piconet to
set up a new piconet with itself as Central and the original piconet Central as
Peripheral. If the original piconet had more than one Peripheral, then this
implies a double role for the original piconet Central; it becomes a Peripheral
in the new piconet while still maintaining the original piconet as Central.

Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
---
 monitor/packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 52d22ab21..f5d90f204 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
 		str = "Stay master";
 		break;
 	case 0x01:
-		str = "Allow slave";
+		str = "Central Or Peripheral";
 		break;
 	default:
 		str = "Reserved";
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927
  2021-07-23  2:03 [PATCH] bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927 wangyouwan
@ 2021-07-23  2:29 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2021-07-23  2:29 UTC (permalink / raw)
  To: linux-bluetooth, wangyouwan

[-- Attachment #1: Type: text/plain, Size: 3059 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=520051

---Test result---

Test Summary:
CheckPatch                    FAIL      0.36 seconds
GitLint                       FAIL      0.12 seconds
Prep - Setup ELL              PASS      44.20 seconds
Build - Prep                  PASS      0.14 seconds
Build - Configure             PASS      7.84 seconds
Build - Make                  PASS      199.70 seconds
Make Check                    PASS      9.32 seconds
Make Distcheck                PASS      232.66 seconds
Build w/ext ELL - Configure   PASS      7.87 seconds
Build w/ext ELL - Make        PASS      190.53 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14: 
• A role switch is necessary in order to make a paging device a Peripheral

- total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] =?UTF-8?q?bluez:fix=20btmon=20tools=20=E2=80=9CAllow=20sl?=" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927
1: T1 Title exceeds max length (84>72): "bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927"


##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-23  2:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23  2:03 [PATCH] bluez:fix btmon tools “Allow slave” to "Central Or Peripheral" #431 [hci0] 99.922927 wangyouwan
2021-07-23  2:29 ` bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).