From: Marcel Holtmann <marcel@holtmann.org>
To: Ayush Garg <ayush.garg@samsung.com>
Cc: linux-bluetooth@vger.kernel.org, anupam.r@samsung.com,
nitin.j@samsung.com
Subject: Re: [PATCH BlueZ 2/8] doc/mgmt-api: Add support for LE PHY Update Complete event
Date: Thu, 22 Jul 2021 16:45:05 +0200 [thread overview]
Message-ID: <63C31A82-0E58-47DA-8F3D-9B1C484E5095@holtmann.org> (raw)
In-Reply-To: <20210722054951.8291-3-ayush.garg@samsung.com>
Hi Ayush,
> Reviewed-by: Anupam Roy <anupam.r@samsung.com>
> ---
> doc/mgmt-api.txt | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 5355fedb0..f7379fcd9 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4910,3 +4910,32 @@ Controller Resume Event
> Address_Type. Otherwise, Address and Address_Type will both be zero.
>
> This event will be sent to all management sockets.
> +
> +
> +LE PHY Update Complete Event
> +===============================
> +
> + Event Code: 0x002f
> + Controller Index: <controller id>
> + Event Parameters: Address (6 Octets)
> + Address_Type (1 Octet)
> + Status (1 Octet)
> + PHYs (4 Octets)
> +
> + This event indicates that LE PHYs have been changed for this
> + connected device.
> +
> + The PHYs parameters are a bitmask with currently the
> + following available bits:
> +
> + 9 LE 1M TX
> + 10 LE 1M RX
> + 11 LE 2M TX
> + 12 LE 2M RX
> + 13 LE Coded TX
> + 14 LE Coded RX
> +
> + This event will be used in case of autonomous PHY update made
> + by the controller or HCI_LE_SET_PHY command succeeded.
> +
> + This event will be sent to all management sockets.
As mentioned in the code review, I don’t like doing it this way.
Regards
Marcel
next prev parent reply other threads:[~2021-07-22 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210722055008epcas5p28da6985b690d3bbc564a5957c1b209f4@epcas5p2.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 0/8] Support for connection specific LE PHY configuration Ayush Garg
[not found] ` <CGME20210722055009epcas5p25e4997aa7e53cb2a6e3780fdb7301785@epcas5p2.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 1/8] doc/device-api: Add Phy property Ayush Garg
2021-07-22 17:33 ` Luiz Augusto von Dentz
[not found] ` <CGME20210722055010epcas5p45a16ff704c37d108a9df0d6c0a1942a8@epcas5p4.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 2/8] doc/mgmt-api: Add support for LE PHY Update Complete event Ayush Garg
2021-07-22 14:45 ` Marcel Holtmann [this message]
[not found] ` <CGME20210722055011epcas5p15299bfe8f8b8dd58e1354364071608e3@epcas5p1.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 3/8] btio: Add BT_IO_PHY option to set le phy options Ayush Garg
[not found] ` <CGME20210722055012epcas5p1bb92b3e31233da03906c4f562b22b4fc@epcas5p1.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 4/8] device: Add support for get/set PHY property Ayush Garg
[not found] ` <CGME20210722055013epcas5p350d88f402bbe4c55f1f868dbb2decbaf@epcas5p3.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 5/8] adapter: Add support for LE PHY Update Complete event Ayush Garg
[not found] ` <CGME20210722055015epcas5p4db389aa15f16f1577a74ba5ce446919b@epcas5p4.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 6/8] client: Add support for LE get/set device PHY in bluetoothctl Ayush Garg
[not found] ` <CGME20210722055016epcas5p267b70f0da3b5c1991d29ca47d685ab6d@epcas5p2.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 7/8] device: Save device PHY in storage and read it at init Ayush Garg
[not found] ` <CGME20210722055017epcas5p4da91b311c34a5fb869148b369338ed07@epcas5p4.samsung.com>
2021-07-22 5:49 ` [PATCH BlueZ 8/8] monitor: Add support for LE PHY Update event Ayush Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63C31A82-0E58-47DA-8F3D-9B1C484E5095@holtmann.org \
--to=marcel@holtmann.org \
--cc=anupam.r@samsung.com \
--cc=ayush.garg@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=nitin.j@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).