archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <>
To: Colin King <>
Cc: Alexander Aring <>,
	Jukka Rissanen <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	Stefan Schmidt <>,
	Bluetooth Kernel Mailing List  <>,,,,
Subject: Re: [PATCH] 6lowpan: iphc: Fix an off-by-one check of array index
Date: Thu, 22 Jul 2021 16:19:46 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Colin,

> The bounds check of id is off-by-one and the comparison should
> be >= rather >. Currently the WARN_ON_ONCE check does not stop
> the out of range indexing of &ldev->ctx.table[id] so also add
> a return path if the bounds are out of range.
> Addresses-Coverity: ("Illegal address computation").
> Fixes: 5609c185f24d ("6lowpan: iphc: add support for stateful compression")
> Signed-off-by: Colin Ian King <>
> ---
> net/6lowpan/debugfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.



      reply	other threads:[~2021-07-22 14:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 12:14 [PATCH] 6lowpan: iphc: Fix an off-by-one check of array index Colin King
2021-07-22 14:19 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).