From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F070C2D0F8 for ; Wed, 13 May 2020 07:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 441EB2078C for ; Wed, 13 May 2020 07:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgEMHuw convert rfc822-to-8bit (ORCPT ); Wed, 13 May 2020 03:50:52 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:47985 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbgEMHuw (ORCPT ); Wed, 13 May 2020 03:50:52 -0400 Received: from [192.168.1.91] (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id E9777CED09; Wed, 13 May 2020 10:00:33 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] build: Add option to disable battery profile From: Marcel Holtmann In-Reply-To: Date: Wed, 13 May 2020 09:50:21 +0200 Cc: Bastien Nocera , Sonny Sasaka , "linux-bluetooth@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <6D33545F-B977-4A46-B1CC-A8DBA391CA65@holtmann.org> References: <20200501215352.23858-1-sonnysasaka@chromium.org> <4A9E7F0B-4AB8-4330-BB2B-1A0EAA4EFDE8@holtmann.org> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, >>> On Wed, 2020-05-06 at 13:24 +0200, Marcel Holtmann wrote: >>>> I have a little bit concern splitting this since battery service and >>>> HoG are kinda connected. Wouldn’t it be better we have a cleaner >>>> interface. Maybe we should actually integrate cleanly with >>>> /dev/upower or similar. >>> >>> Wat? >> >> I guess Marcel was refering to something like uhid though Im not sure >> that exists, or does it? That said one alternative would make uhid >> integrate the battery status, but I guess devices can also expose this >> over hid directly so I wonder if we can translate the Battery Service >> status to hid power strength that way we don't need any communication >> over D-Bus. > > Btw, Im fine with the option to disable building the battery plugin > since platforms may not have a use for it, so except if there are some > strong reason against it I will apply the patch. lets wait and see if we can actually generalize this feature. Regards Marcel