From: "Stotland, Inga" <inga.stotland@intel.com>
To: "michal.lowas-rzechonek@silvair.com"
<michal.lowas-rzechonek@silvair.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Cc: "Gix, Brian" <brian.gix@intel.com>
Subject: Re: [PATCH BlueZ v6 0/5] Use composition data to validate app against the
Date: Fri, 26 Jul 2019 14:24:45 +0000 [thread overview]
Message-ID: <6a64704d5d247f969758149a0df77c4465aadade.camel@intel.com> (raw)
In-Reply-To: <20190726063606.19359-1-michal.lowas-rzechonek@silvair.com>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
Hi Michal,
On Fri, 2019-07-26 at 08:36 +0200, Michał Lowas-Rzechonek wrote:
> Thanks for your patience :)
>
> + Fix brace style
> + Fix comment style
> + Fix typo when assigning element paths in attach_req_node
> + Fix setting app_path and owner during Attach()
> + Fix typo CompanyID property validation
> + Added comments about temporary node usage during Attach()
> + Keep element's Location property optional according to API
> documentation
>
> ---
>
> This patchset streamlines app validation by creating a temporary node
> during Attach, Join and CreateNetwork calls, then validating its
> composition data to:
> - fit in Config Model Composition Data Get message
> - declare mandatory models on primary element
> - declare consecutive element indexes
>
> During Attach call, temporary composition data is also compared with
> data generated for existing node, guaranteeing immutablity required
> by
> the specification.
>
> Michał Lowas-Rzechonek (5):
> mesh: Convert void pointers to anonymous unions in
> managed_obj_request
> mesh: Validate application by comparing composition data
> mesh: Keep element and model lists sorted and unique
> mesh: Check that element indexes are consecutive
> mesh: Check that config server is present in primary element
>
> mesh/mesh-defs.h | 2 +
> mesh/node.c | 556 ++++++++++++++++++++++++---------------------
> --
> 2 files changed, 290 insertions(+), 268 deletions(-)
>
The patch set looks good.
Thanks,
Inga
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3265 bytes --]
next prev parent reply other threads:[~2019-07-26 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 6:36 [PATCH BlueZ v6 0/5] Use composition data to validate app against the Michał Lowas-Rzechonek
2019-07-26 6:36 ` [PATCH BlueZ v6 1/5] mesh: Convert void pointers to anonymous unions in managed_obj_request Michał Lowas-Rzechonek
2019-07-26 6:36 ` [PATCH BlueZ v6 2/5] mesh: Validate application by comparing composition data Michał Lowas-Rzechonek
2019-07-26 6:36 ` [PATCH BlueZ v6 3/5] mesh: Keep element and model lists sorted and unique Michał Lowas-Rzechonek
2019-07-26 6:36 ` [PATCH BlueZ v6 4/5] mesh: Check that element indexes are consecutive Michał Lowas-Rzechonek
2019-07-26 6:36 ` [PATCH BlueZ v6 5/5] mesh: Check that config server is present in primary element Michał Lowas-Rzechonek
2019-07-26 14:24 ` Stotland, Inga [this message]
2019-07-26 16:19 ` [PATCH BlueZ v6 0/5] Use composition data to validate app against the Gix, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a64704d5d247f969758149a0df77c4465aadade.camel@intel.com \
--to=inga.stotland@intel.com \
--cc=brian.gix@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.lowas-rzechonek@silvair.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).