Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
From: Balakrishna Godavarthi <bgodavar@codeaurora.org>
To: Harish Bandi <c-hbandi@codeaurora.org>
Cc: Claire Chang <tientzu@chromium.org>,
	marcel@holtmann.org, johan.hedberg@gmail.com,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	rjliao@codeaurora.org, rongchi@codeaurora.org,
	linux-bluetooth-owner@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement
Date: Fri, 11 Oct 2019 12:51:40 +0530
Message-ID: <74740c0ff64a6a658da2a44a9f9b7ac5@codeaurora.org> (raw)
In-Reply-To: <238f01ec4b49fee4c0d08a0b8da7e95f@codeaurora.org>

Hi Claire,

This change will not work  as we need fw files to be loaded tofor IBS to 
active.
may i know on which chipset you have this issue of IBS active even with 
out fw download.

On 2019-10-11 12:31, Harish Bandi wrote:
> ++ Balakrishna
> 
> On 2019-10-09 14:21, Claire Chang wrote:
>> Enabling in-band sleep when there is no patch/nvm-config found and
>> bluetooth is running with the original fw/config.
>> 
>> Fixes: ba8f35979002 ("Bluetooth: hci_qca: Avoid setup failure on
>> missing rampatch")
>> Fixes: 7dc5fe0814c3 ("Bluetooth: hci_qca: Avoid missing rampatch
>> failure with userspace fw loader")
>> Signed-off-by: Claire Chang <tientzu@chromium.org>
>> ---
>>  drivers/bluetooth/hci_qca.c | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index e3164c200eac..367eef893a11 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1291,10 +1291,8 @@ static int qca_setup(struct hci_uart *hu)
>>  	/* Setup patch / NVM configurations */
>>  	ret = qca_uart_setup(hdev, qca_baudrate, soc_type, soc_ver,
>>  			firmware_name);
>> -	if (!ret) {
>> -		set_bit(QCA_IBS_ENABLED, &qca->flags);
>> -		qca_debugfs_init(hdev);
>> -	} else if (ret == -ENOENT) {
>> +
>> +	if (ret == -ENOENT) {
>>  		/* No patch/nvm-config found, run with original fw/config */
>>  		ret = 0;
>>  	} else if (ret == -EAGAIN) {
>> @@ -1305,6 +1303,11 @@ static int qca_setup(struct hci_uart *hu)
>>  		ret = 0;
>>  	}
>> 
>> +	if (!ret) {
>> +		set_bit(QCA_IBS_ENABLED, &qca->flags);
>> +		qca_debugfs_init(hdev);
>> +	}
>> +
>>  	/* Setup bdaddr */
>>  	if (qca_is_wcn399x(soc_type))
>>  		hu->hdev->set_bdaddr = qca_set_bdaddr;

-- 
Regards
Balakrishna.

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09  8:51 Claire Chang
2019-10-11  7:01 ` Harish Bandi
2019-10-11  7:21   ` Balakrishna Godavarthi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-09  8:37 Claire Chang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74740c0ff64a6a658da2a44a9f9b7ac5@codeaurora.org \
    --to=bgodavar@codeaurora.org \
    --cc=c-hbandi@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth-owner@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rjliao@codeaurora.org \
    --cc=rongchi@codeaurora.org \
    --cc=tientzu@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox