Re: [PATCH BlueZ v3 0/3] mesh: Fix Remote/Local dev key usage

["Stotland, Inga" <inga.stotland@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi Brian,

On Thu, 2019-09-26 at 11:14 -0700, Brian Gix wrote:
> V3:  By popular demand, the name "remote" is now used for both
> DevKeySend()
> and DevKeyMessageReceived().
> 
> In DevKeySend(), setting remote == true means that the Key Ring
> *must* be
> used to encrypt the outgoing message, and a failure will be returned
> if
> the requested destination address does not include a device key in
> the
> local key ring. For remote == false requests, the request will be
> rejected
> if the destination is an element on the local node.
> 
> In DevKeyMessageReceived(), the remote boolean will be set == true if
> it
> required the key ring to decrypot the message.  If remote == false,
> this
> means that the local nodes Device Key successfully decrypted the
> message,
> and the message may be used to change or query privileged states.
> 
> 
> Brian Gix (3):
>   mesh: Add local/remote bools to DevKey transactions
>   mesh: Use explicit Local vs Remote Device key usage
> 

The two patches above are fine IMO (see some comments for #2, but these
can be addressed in a separate patch)

>   mesh: Fix Key Ring permissions for local nodes

This patch may require some explanation?

> 
>  doc/mesh-api.txt | 17 ++++++++++++++---
>  mesh/manager.c   |  5 -----
>  mesh/model.c     | 11 +++++++----
>  mesh/node.c      | 40 +++++++++++++++-------------------------
>  4 files changed, 36 insertions(+), 37 deletions(-)
> 




[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3265 bytes --]