From: Thorsten Leemhuis <email@example.com> To: Joey Corleone <firstname.lastname@example.org>, Marcel Holtmann <email@example.com>, Luiz Augusto von Dentz <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync Date: Tue, 10 May 2022 17:29:17 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 10.05.22 12:36, Joey Corleone wrote: > On 24.02.22 21:08, Marcel Holtmann wrote: >>> hci_update_accept_list_sync is returning the filter based on the error >>> but that gets overwritten by hci_le_set_addr_resolution_enable_sync >>> return instead of using the actual result of the likes of >>> hci_le_add_accept_list_sync which was intended. >>> >>> Fixes: ad383c2c65a5b ("Bluetooth: hci_sync: Enable advertising when >>> LL privacy is enabled") >>> Signed-off-by: Luiz Augusto von Dentz <email@example.com> >>> --- >>> v2: Use u8 filter_policy instead of int ret as variable to store the >>> result. >>> >>> net/bluetooth/hci_sync.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> patch has been applied to bluetooth-stable tree. >> >> Regards >> >> Marcel > > Just to put you in the loop in case you have not noticed it yet: there > seems to be some kind of regression introduced by this patch. See > comment #5 of ticket 215768 where Damien Thébault bisected the kernel . Thx for CCing the regressions list. [TLDR: I'm adding this regression report to the list of tracked regressions; all text from me you find below is based on a few templates paragraphs you might have encountered already already in similar form.] To be sure below issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot: #regzbot ^introduced 80740ebb7e1ad #regzbot title net: bluetooth: can't suspend while bluetooth is enabled. #regzbot ignore-activity #regzbot from: plum <firstname.lastname@example.org> #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215768 This isn't a regression? This issue or a fix for it are already discussed somewhere else? It was fixed already? You want to clarify when the regression started to happen? Or point out I got the title or something else totally wrong? Then just reply -- ideally with also telling regzbot about it, as explained here: https://linux-regtracking.leemhuis.info/tracked-regression/ Reminder for developers: When fixing the issue, add 'Link:' tags pointing to the report (the mail this one replied to), as the kernel's documentation call for; above page explains why this is important for tracked regressions. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
next prev parent reply other threads:[~2022-05-10 15:31 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-24 15:11 Luiz Augusto von Dentz 2022-02-24 16:04 ` [v2] " bluez.test.bot 2022-02-24 20:08 ` [PATCH v2] " Marcel Holtmann 2022-05-10 10:36 ` Joey Corleone 2022-05-10 15:29 ` Thorsten Leemhuis [this message] 2022-05-16 12:40 ` [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync #forregzbot Thorsten Leemhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v2] Bluetooth: hci_sync: Fix hci_update_accept_list_sync' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).