From: Rocky Liao <rjliao@codeaurora.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
thierry.escande@linaro.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
Date: Wed, 24 Apr 2019 14:19:08 +0800
Message-ID: <7e0cf9ba98260309c43d9d6e63dead6c@codeaurora.org> (raw)
In-Reply-To: <A85D7982-E000-4A5F-9927-CA36E0BA60F2@holtmann.org>
On 2019-04-24 01:06, Marcel Holtmann wrote:
> Hi Rocky,
>
>> This patch adds an optional device property "firmware-name" to allow
>> the
>> driver to load customized nvm firmware file based on this property.
>>
>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>> ---
>> Changes in v3:
>> * added firmware-name instead of nvm-postfix to specify full firmware
>> name
>> ---
>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 824c0e2..2bcea50 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -16,6 +16,7 @@ Optional properties for compatible string
>> qcom,qca6174-bt:
>>
>> - enable-gpios: gpio specifier used to enable chip
>> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>> + - firmware-name: specify the name of nvm firmware to load
>>
>> Required properties for compatible string qcom,wcn3990-bt:
>>
>> @@ -39,6 +40,7 @@ serial@7570000 {
>>
>> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>> clocks = <&divclk4>;
>> + firmware-name = "nvm_00440302.bin";
>> };
>
> and how is this a firmware-name property. Wouldn’t this be more like
> nvm-file or something along these lines. This really needs to be
> cleared with Rob to pick the right property name.
>
> Regards
>
> Marcel
Hi Rob,
Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
Actually we have two firmware files, one is the patch file which is
common to all of the products, the other is the nvm file which is
customized. Using a "nvm-file" or "firmware-nvm-file" property name
would be more clear.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply index
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 6:37 [PATCH] Bluetooth: hci_qca: Load customized NVM based on the device property Rocky Liao
2019-04-04 6:56 ` Balakrishna Godavarthi
2019-04-04 9:08 ` [PATCH v2 1/2] " Rocky Liao
2019-04-04 9:08 ` [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device property nvm-postfix for QCA6174 Rocky Liao
2019-04-04 12:32 ` Marc Gonzalez
2019-04-09 10:15 ` Rocky Liao
2019-04-09 14:03 ` Rob Herring
2019-04-09 14:48 ` Rocky Liao
2019-04-09 13:54 ` Rob Herring
2019-04-10 9:27 ` [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name " Rocky Liao
2019-04-23 17:06 ` Marcel Holtmann
2019-04-24 6:19 ` Rocky Liao [this message]
2019-04-26 17:45 ` Rob Herring
2019-04-27 5:59 ` Marcel Holtmann
2019-05-03 7:56 ` Rocky Liao
2019-05-05 17:32 ` Marcel Holtmann
2019-04-26 20:50 ` Rob Herring
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2019-05-13 15:31 ` Rob Herring
2019-05-15 11:20 ` [PATCH v5 " Rocky Liao
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
2019-06-11 22:01 ` Rob Herring
2019-07-06 10:56 ` Marcel Holtmann
2019-04-04 9:59 ` [PATCH v2 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property Balakrishna Godavarthi
2019-04-10 9:27 ` [PATCH v3 " Rocky Liao
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2019-05-15 5:32 ` Balakrishna Godavarthi
2019-05-15 8:30 ` Rocky Liao
2019-05-15 11:19 ` [PATCH v5 " Rocky Liao
2019-05-17 2:43 ` Balakrishna Godavarthi
2019-05-17 4:26 ` Harish Bandi
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
2019-06-06 12:02 ` Harish Bandi
2019-07-06 10:51 ` Marcel Holtmann
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0cf9ba98260309c43d9d6e63dead6c@codeaurora.org \
--to=rjliao@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Bluetooth Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
public-inbox-index linux-bluetooth
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth
AGPL code for this site: git clone https://public-inbox.org/ public-inbox