Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ] mesh: Fix BeaconFlags property type
@ 2020-01-08 21:51 Michał Lowas-Rzechonek
  2020-01-08 22:05 ` Gix, Brian
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Lowas-Rzechonek @ 2020-01-08 21:51 UTC (permalink / raw)
  To: linux-bluetooth

This property is an uint8, not a boolean.

---
 mesh/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mesh/node.c b/mesh/node.c
index 032216774..13d4d3418 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -2358,7 +2358,7 @@ static void setup_node_interface(struct l_dbus_interface *iface)
 	l_dbus_interface_property(iface, "Features", 0, "a{sv}", features_getter,
 									NULL);
 	l_dbus_interface_property(iface, "Beacon", 0, "b", beacon_getter, NULL);
-	l_dbus_interface_property(iface, "BeaconFlags", 0, "b",
+	l_dbus_interface_property(iface, "BeaconFlags", 0, "y",
 						beaconflags_getter, NULL);
 	l_dbus_interface_property(iface, "IvIndex", 0, "u", ivindex_getter,
 									NULL);
-- 
2.23.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] mesh: Fix BeaconFlags property type
  2020-01-08 21:51 [PATCH BlueZ] mesh: Fix BeaconFlags property type Michał Lowas-Rzechonek
@ 2020-01-08 22:05 ` Gix, Brian
  0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2020-01-08 22:05 UTC (permalink / raw)
  To: michal.lowas-rzechonek, linux-bluetooth

Applied
On Wed, 2020-01-08 at 22:51 +0100, Michał Lowas-Rzechonek wrote:
> This property is an uint8, not a boolean.
> 
> ---
>  mesh/node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mesh/node.c b/mesh/node.c
> index 032216774..13d4d3418 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -2358,7 +2358,7 @@ static void setup_node_interface(struct l_dbus_interface *iface)
>  	l_dbus_interface_property(iface, "Features", 0, "a{sv}", features_getter,
>  									NULL);
>  	l_dbus_interface_property(iface, "Beacon", 0, "b", beacon_getter, NULL);
> -	l_dbus_interface_property(iface, "BeaconFlags", 0, "b",
> +	l_dbus_interface_property(iface, "BeaconFlags", 0, "y",
>  						beaconflags_getter, NULL);
>  	l_dbus_interface_property(iface, "IvIndex", 0, "u", ivindex_getter,
>  									NULL);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 21:51 [PATCH BlueZ] mesh: Fix BeaconFlags property type Michał Lowas-Rzechonek
2020-01-08 22:05 ` Gix, Brian

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git