* [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value
@ 2021-10-02 18:21 Tedd Ho-Jeong An
2021-10-02 20:52 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Tedd Ho-Jeong An @ 2021-10-02 18:21 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Tedd Ho-Jeong An
From: Tedd Ho-Jeong An <tedd.an@intel.com>
This patch sets the wakeup value in the vhci driver data after reading
the value.
Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
---
drivers/bluetooth/hci_vhci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index b45db0db347c..5fd91106e853 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
if (data->wakeup == enable)
return -EALREADY;
+ data->wakeup = enable;
+
return count;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value
2021-10-02 18:21 [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value Tedd Ho-Jeong An
@ 2021-10-02 20:52 ` Marcel Holtmann
2021-10-04 22:27 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2021-10-02 20:52 UTC (permalink / raw)
To: Tedd Ho-Jeong An; +Cc: linux-bluetooth, Tedd Ho-Jeong An
Hi Tedd,
> This patch sets the wakeup value in the vhci driver data after reading
> the value.
>
> Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> ---
> drivers/bluetooth/hci_vhci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> index b45db0db347c..5fd91106e853 100644
> --- a/drivers/bluetooth/hci_vhci.c
> +++ b/drivers/bluetooth/hci_vhci.c
> @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> if (data->wakeup == enable)
> return -EALREADY;
>
> + data->wakeup = enable;
> +
> return count;
patch looks good, but the commit message is confusing.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value
2021-10-02 20:52 ` Marcel Holtmann
@ 2021-10-04 22:27 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-10-04 22:27 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Tedd Ho-Jeong An, linux-bluetooth, Tedd Ho-Jeong An
Hi Marcel, Tedd,
On Sat, Oct 2, 2021 at 2:04 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Tedd,
>
> > This patch sets the wakeup value in the vhci driver data after reading
> > the value.
> >
> > Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> > ---
> > drivers/bluetooth/hci_vhci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> > index b45db0db347c..5fd91106e853 100644
> > --- a/drivers/bluetooth/hci_vhci.c
> > +++ b/drivers/bluetooth/hci_vhci.c
> > @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> > if (data->wakeup == enable)
> > return -EALREADY;
> >
> > + data->wakeup = enable;
> > +
> > return count;
>
> patch looks good, but the commit message is confusing.
Ive ended up fixing the original patch since I had to force push due
to the pull request problem with committer/sign-off problem.
> Regards
>
> Marcel
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02 18:21 [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value Tedd Ho-Jeong An
2021-10-02 20:52 ` Marcel Holtmann
2021-10-04 22:27 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).