From: Marcel Holtmann <marcel@holtmann.org>
To: Alain Michaud <alainm@chromium.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>
Subject: Re: [BlueZ PATCH 0/2] HID and HOGP connections from non-bonded devices.
Date: Tue, 10 Mar 2020 06:24:21 +0100 [thread overview]
Message-ID: <87A4E633-63CF-4C71-9BF6-916894790EED@holtmann.org> (raw)
In-Reply-To: <20200310023516.209146-1-alainm@chromium.org>
Hi Alain,
> It was discovered that BlueZ's HID and HOGP profiles implementations
> don't specifically require bonding between the device and the host.
>
> This creates an opportunity for an malicious device to connect to a
> target host to either impersonate an existing HID device without
> security or to cause an SDP or GATT service discovery to take place
> which would allow HID reports to be injected to the input subsystem from
> a non-bonded source.
>
> This patch series addresses the issue by ensuring that only connections
> from devices that are bonded are accepted by the HID and HOGP profile
> implementation.
>
> More information about the vulnerability is available here:
> https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00352.html
>
> Alain Michaud (2):
> HOGP must only accept data from bonded devices.
> HID accepts bonded device connections only.
>
> profiles/input/device.c | 23 ++++++++++++++++++++++-
> profiles/input/device.h | 1 +
> profiles/input/hog.c | 4 ++++
> profiles/input/input.conf | 8 ++++++++
> profiles/input/manager.c | 13 ++++++++++++-
> 5 files changed, 47 insertions(+), 2 deletions(-)
both patches have been applied.
However I changed BrBondedOnly configuration name into ClassicBondedOnly since that name seemed more obvious to me. The prefix Br has never been used and the Bluetooth SIG started calling it Classic a while back.
Regards
Marcel
next prev parent reply other threads:[~2020-03-10 5:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 2:35 [BlueZ PATCH 0/2] HID and HOGP connections from non-bonded devices Alain Michaud
2020-03-10 2:35 ` [BlueZ PATCH 1/2] HOGP must only accept data from bonded devices Alain Michaud
2020-03-10 6:04 ` Luiz Augusto von Dentz
2020-03-10 2:35 ` [BlueZ PATCH 2/2] HID accepts bonded device connections only Alain Michaud
2020-03-10 6:22 ` Luiz Augusto von Dentz
2020-03-10 5:24 ` Marcel Holtmann [this message]
2020-03-10 6:27 ` [BlueZ PATCH 0/2] HID and HOGP connections from non-bonded devices Luiz Augusto von Dentz
2020-03-10 12:30 ` Alain Michaud
2020-03-10 17:12 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87A4E633-63CF-4C71-9BF6-916894790EED@holtmann.org \
--to=marcel@holtmann.org \
--cc=alainm@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).