Re: [PATCH] btusb: Add shutdown routine for BTUSB_INTEL_NEW devices

From: Marcel Holtmann <marcel@holtmann.org>
To: Raghuram Hegde <raghuram.hegde@intel.com>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	Chethan T N <chethan.tumkur.narayan@intel.com>
Subject: Re: [PATCH] btusb: Add shutdown routine for BTUSB_INTEL_NEW devices
Date: Mon, 28 Jan 2019 13:05:01 +0100	[thread overview]
Message-ID: <91F174CE-3CBE-4D3B-B0C9-E350C01F3DDF@holtmann.org> (raw)
In-Reply-To: <1548665625-23742-1-git-send-email-raghuram.hegde@intel.com>

Hi Raghuram,

> btusb_shutdown_intel routine shall reset the controller
> and stop all BT operation.
> Advantages:
> 	1. Power save on the platform
> 	2. Host and controller will be in Sync.
> 
> Signed-off-by: Raghuram Hegde <raghuram.hegde@intel.com>
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5de0c2e59b97..66483ca3d870 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3139,6 +3139,7 @@ static int btusb_probe(struct usb_interface *intf,
> 		hdev->manufacturer = 2;
> 		hdev->send = btusb_send_frame_intel;
> 		hdev->setup = btusb_setup_intel_new;
> +		hdev->shutdown = btusb_shutdown_intel;
> 		hdev->hw_error = btintel_hw_error;
> 		hdev->set_diag = btintel_set_diag;
> 		hdev->set_bdaddr = btintel_set_bdaddr;

I assumed that this was only needed for the older ROM versions of the Intel controllers and not the newer RAM versions. I have been told they don’t inherit the LED issue that we tried to fix with this. Please read the comments in btusb_shutdown_intel and amend comments if needed and provide a detailed commit message.

Regards

Marcel