From: "Gix, Brian" <brian.gix@intel.com>
To: "michal.lowas-rzechonek@silvair.com"
<michal.lowas-rzechonek@silvair.com>,
"Stotland, Inga" <inga.stotland@intel.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address
Date: Fri, 27 Sep 2019 15:01:04 +0000 [thread overview]
Message-ID: <9b14b4b5ae3a0a04f441ff750da107022a4066c9.camel@intel.com> (raw)
In-Reply-To: <20190927085208.sxy2x5656ci3opo6@mlowasrzechonek2133>
Hi Michał, Inga,
On Fri, 2019-09-27 at 10:52 +0200, michal.lowas-rzechonek@silvair.com wrote:
> Inga, Brian,
>
> On 09/26, Stotland, Inga wrote:
> > While I am still in favor of two distinct methods (given choice, I'd
> > always go with self-explanatory API)
>
> So do I.
>
> > I vote against u16 destination field since there is no reason to
> > create address space collision even though the chances are small.
> >
> > A single method "MessageReceived" method can be modified to include a
> > subscription parameter as:
> > 1) a dictionary with keys "Group" and "Label" (self explanatory if a
> > bit cumbersome).
>
> If we really need to avoid two separate methods, I think it would be a
> bit cleaner to pass this parameter as a D-Bus variant of (u16,
> array[16]) instead of a dictionary.
Here is an interesting idea...
Is it possible to use a variable sized array for the address?
0 octets -- Destination is the Unicast address
2 octets -- Destination is a network byte ordere (Big Endian) u16
16 octets -- Destination is a 128bit Virtual label
The caveat here is that there would be two variable octet arrays in the message,
but from a D-Bus efficiency standpoint, might be the best we are going to do.
>
next prev parent reply other threads:[~2019-09-27 15:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:43 mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address Michał Lowas-Rzechonek
2019-09-04 19:25 ` Michał Lowas-Rzechonek
2019-09-04 19:48 ` Michał Lowas-Rzechonek
2019-09-04 20:26 ` Gix, Brian
2019-09-04 22:39 ` Stotland, Inga
2019-09-05 7:29 ` michal.lowas-rzechonek
2019-09-05 7:34 ` michal.lowas-rzechonek
2019-09-18 8:52 ` Michał Lowas-Rzechonek
2019-09-18 12:36 ` Michał Lowas-Rzechonek
2019-09-25 19:02 ` Stotland, Inga
2019-09-26 15:18 ` Gix, Brian
2019-09-26 20:41 ` Stotland, Inga
2019-09-26 23:48 ` Gix, Brian
2019-09-27 2:54 ` Stotland, Inga
2019-09-27 8:52 ` michal.lowas-rzechonek
2019-09-27 15:01 ` Gix, Brian [this message]
2019-09-27 15:50 ` Gix, Brian
2019-09-27 17:25 ` Stotland, Inga
2019-09-27 19:25 ` Gix, Brian
2019-09-30 7:18 ` michal.lowas-rzechonek
2019-09-30 16:34 ` Stotland, Inga
2019-09-30 17:57 ` Gix, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b14b4b5ae3a0a04f441ff750da107022a4066c9.camel@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michal.lowas-rzechonek@silvair.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).