From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Iulia Tanasescu <iulia.tanasescu@nxp.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/1] Bluetooth: Add support for creating multiple BISes
Date: Wed, 17 May 2023 09:33:17 +0200 [thread overview]
Message-ID: <9c4c67d0-7a51-5dbf-a05c-46103c694f39@molgen.mpg.de> (raw)
In-Reply-To: <20230517072706.5988-2-iulia.tanasescu@nxp.com>
Dear Iulia,
Thank you for your patch.
Am 17.05.23 um 09:27 schrieb Iulia Tanasescu:
> It is required for some configurations to have multiple BISes as part
> of the same BIG, which is now covered by iso-tester in the following test
> case:
>
> ISO Broadcaster AC 13 - Success
Thank you for adding a test. Did you also test it on hardware? If so,
please document your test setup.
A diffstat over hundred lines should have a more elaborate commit
message. Could you please add a short note about the implementation?
> Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
> ---
> include/net/bluetooth/bluetooth.h | 2 +
> include/net/bluetooth/hci.h | 7 ++
> include/net/bluetooth/hci_core.h | 32 ++++++-
> include/net/bluetooth/iso.h | 14 +++
> net/bluetooth/hci_conn.c | 150 ++++++++++++++++++++++++------
> net/bluetooth/hci_core.c | 18 ++++
> net/bluetooth/hci_event.c | 98 +++++++++++++++----
> net/bluetooth/iso.c | 4 +
> 8 files changed, 277 insertions(+), 48 deletions(-)
>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index 1b4230cd42a3..28a3b105fdf3 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -198,6 +198,8 @@ struct bt_iso_bcast_qos {
> __u8 sync_cte_type;
> __u8 mse;
> __u16 timeout;
> + __u8 dummy[2]; /* Dummy octets for padding compatibility with old BlueZ */
> + __u8 num_bis;
> };
>
> struct bt_iso_qos {
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 07df96c47ef4..7567cbecf937 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1,6 +1,7 @@
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> + Copyright 2023 NXP
Above, Copyright is followed by (C). Should it be consistent?
[…]
Kind regards,
Paul
next prev parent reply other threads:[~2023-05-17 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 7:27 [PATCH 0/1] Bluetooth: Add support for creating multiple BISes Iulia Tanasescu
2023-05-17 7:27 ` [PATCH 1/1] " Iulia Tanasescu
2023-05-17 7:33 ` Paul Menzel [this message]
2023-05-18 7:19 ` Iulia Tanasescu
2023-05-17 7:57 ` bluez.test.bot
2023-05-17 17:55 ` [PATCH 1/1] " Luiz Augusto von Dentz
2023-05-18 7:15 ` Iulia Tanasescu
2023-05-18 17:13 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4c67d0-7a51-5dbf-a05c-46103c694f39@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=iulia.tanasescu@nxp.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).