linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Jupeng Zhong <zjp734690220@163.com>
Cc: zhongjupeng <zhongjupeng@yulong.com>,
	"Johan Hedberg" <johan.hedberg@gmail.com>,
	"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
	"Bluetooth Kernel Mailing List" <linux-bluetooth@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt_recv
Date: Mon, 1 Feb 2021 11:45:02 +0100	[thread overview]
Message-ID: <A3F983DE-36C0-43EB-BE8F-086FECCE63B8@holtmann.org> (raw)
In-Reply-To: <20210201120853.00002791@163.com>

Hi Jupeng,

>>>> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should
>>>> be released.
>>>> 
>>>> Signed-off-by: zhongjupeng <zhongjupeng@yulong.com>    
>>> 
>>> please provide a proper From: and Signed-off-by line with full name.
>>> 
>>> Regards
>>> 
>>> Marcel  
>> 
>>  Hi,
>> 
>> 
>>    Update the patch From: and Signed-off-by: as follows:
>> 
>> 	Jupeng Zhong <zhongjupeng@yulong.com>
> 
> 
>  Hi,
> 
>    Thanks to Markus Elfring for the suggestion:
> 
>    1. add the tag “Fixes”.
>    2. omit the labels “err_out” and “err_free_skb” in this function
>       implementation.
> 
>    The patch has been updated, please check.
> 
>    Thanks.
> <0001-Bluetooth-btusb-Fix-memory-leak-in-btusb_mtk_wmt_rec.patch>

please send patch inline via git-send-email or similar so that they are easy to review.

Regards

Marcel



      parent reply	other threads:[~2021-02-01 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  2:08 [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt_recv zjp734690220
2021-01-29  3:27 ` bluez.test.bot
     [not found] ` <949194D0-DD66-4626-8577-9F228D142BF9@holtmann.org>
     [not found]   ` <20210130153909.00001f48@163.com>
     [not found]     ` <20210201120853.00002791@163.com>
2021-02-01 10:45       ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A3F983DE-36C0-43EB-BE8F-086FECCE63B8@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=Markus.Elfring@web.de \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=zhongjupeng@yulong.com \
    --cc=zjp734690220@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).