Re: [PATCH BlueZ v5 04/30] mesh: Internal errors

[Marcel Holtmann <marcel@holtmann.org>]

Hi Brian,

> ---
> mesh/error.h | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 mesh/error.h
> 
> diff --git a/mesh/error.h b/mesh/error.h
> new file mode 100644
> index 000000000..acb4efaac
> --- /dev/null
> +++ b/mesh/error.h
> @@ -0,0 +1,35 @@
> +/*
> + *
> + *  BlueZ - Bluetooth protocol stack for Linux
> + *
> + *  Copyright (C) 2018  Intel Corporation. All rights reserved.
> + *
> + *
> + *  This library is free software; you can redistribute it and/or
> + *  modify it under the terms of the GNU Lesser General Public
> + *  License as published by the Free Software Foundation; either
> + *  version 2.1 of the License, or (at your option) any later version.
> + *
> + *  This library is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *  Lesser General Public License for more details.
> + *
> + *

extra line here. Can we please get this right.

> + */
> +
> +/*
> + * Important: Changes in this table must be reflected in the
> + * the entries of error_table[] in dbus.c
> + */
> +enum mesh_error {
> +	MESH_ERROR_NONE,
> +	MESH_ERROR_FAILED,
> +	MESH_ERROR_NOT_AUTHORIZED,
> +	MESH_ERROR_NOT_FOUND,
> +	MESH_ERROR_INVALID_ARGS,
> +	MESH_ERROR_BUSY,
> +	MESH_ERROR_ALREADY_EXISTS,
> +	MESH_ERROR_DOES_NOT_EXIST,
> +	MESH_ERROR_CANCELED,
> +};

I am not 100% sure this is the best choice on how to handle this. It is for sure error prone and frankly this should be merged into the previous patch for sure. Personally I think you guys are over-optimizing here for no real gain.

Regards

Marcel