From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C92C41604 for ; Sat, 3 Oct 2020 18:33:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA82320738 for ; Sat, 3 Oct 2020 18:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725821AbgJCSdU convert rfc822-to-8bit (ORCPT ); Sat, 3 Oct 2020 14:33:20 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:56866 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbgJCSdU (ORCPT ); Sat, 3 Oct 2020 14:33:20 -0400 Received: from marcel-macpro.fritz.box (p4fefc7f4.dip0.t-ipconnect.de [79.239.199.244]) by mail.holtmann.org (Postfix) with ESMTPSA id 1C33DCED05; Sat, 3 Oct 2020 20:40:19 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" From: Marcel Holtmann In-Reply-To: <20201003160713.GA1512229@kroah.com> Date: Sat, 3 Oct 2020 20:33:18 +0200 Cc: Johan Hedberg , Sathish Narsimman , "David S. Miller" , Jakub Kicinski , linux-bluetooth , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20201003135449.GA2691@kroah.com> <20201003160713.GA1512229@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.3608.120.23.2.1) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Greg, >>> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it >>> breaks all bluetooth connections on my machine. >>> >>> Cc: Marcel Holtmann >>> Cc: Sathish Narsimman >>> Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist") >>> Signed-off-by: Greg Kroah-Hartman >>> --- >>> net/bluetooth/hci_request.c | 41 ++----------------------------------- >>> 1 file changed, 2 insertions(+), 39 deletions(-) >>> >>> This has been bugging me for since 5.9-rc1, when all bluetooth devices >>> stopped working on my desktop system. I finally got the time to do >>> bisection today, and it came down to this patch. Reverting it on top of >>> 5.9-rc7 restored bluetooth devices and now my input devices properly >>> work. >>> >>> As it's almost 5.9-final, any chance this can be merged now to fix the >>> issue? >> >> can you be specific what breaks since our guys and I also think the >> ChromeOS guys have been testing these series of patches heavily. > > My bluetooth trackball does not connect at all. With this reverted, it > all "just works". > > Same I think for a Bluetooth headset, can check that again if you really > need me to, but the trackball is reliable here. > >> When you run btmon does it indicate any errors? > > How do I run it and where are the errors displayed? you can do btmon -w trace.log and just let it run like tcdpump. >> Do you have a chance to test net-next and see the LL Privacy there might have addressed this? > > Have a specific set of patches I can test? It wouldn't be good to have > 5.9-final go out with this not working at all. Of course not, but so far you are the only one reported a problem. Maybe you have some funky hardware in your machine that needs a quirk. Regards Marcel