From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB02CA9EAF for ; Mon, 21 Oct 2019 15:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B21020873 for ; Mon, 21 Oct 2019 15:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbfJUPOT convert rfc822-to-8bit (ORCPT ); Mon, 21 Oct 2019 11:14:19 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:42578 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727355AbfJUPOS (ORCPT ); Mon, 21 Oct 2019 11:14:18 -0400 Received: from marcel-macbook.fritz.box (p4FEFC197.dip0.t-ipconnect.de [79.239.193.151]) by mail.holtmann.org (Postfix) with ESMTPSA id 1DA90CECC4; Mon, 21 Oct 2019 17:23:16 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\)) Subject: Re: [PATCHv2 4/4] Bluetooth: btwilink: drop superseded driver From: Marcel Holtmann In-Reply-To: <20191020205901.56bafijk7cu3rpaj@earth.universe> Date: Mon, 21 Oct 2019 17:14:15 +0200 Cc: Tony Lindgren , Adam Ford , Enric Balletbo i Serra , linux-bluetooth@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20191003134147.9458-1-sre@kernel.org> <20191003134147.9458-5-sre@kernel.org> <20191020205901.56bafijk7cu3rpaj@earth.universe> To: Sebastian Reichel X-Mailer: Apple Mail (2.3594.4.19) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Sebastian, >>> All users of this driver have been converted to the serdev based >>> hci_ll driver. The unused driver can be safely dropped now. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >>> drivers/bluetooth/Kconfig | 11 -- >>> drivers/bluetooth/Makefile | 1 - >>> drivers/bluetooth/btwilink.c | 337 ----------------------------------- >>> 3 files changed, 349 deletions(-) >>> delete mode 100644 drivers/bluetooth/btwilink.c >> >> patch has been applied to bluetooth-next tree. >> >> However what I really like to see is that you re-introduce a >> btwilink driver that is purely serdev based and doesn’t rely on >> any hci_uart/hci_ldisc code. A clean serdev only driver is that >> best and easier to maintain long term. > > So basically move the serdev implementation from hci_ll.c into its > own driver and make hci_ll hci_uart based only? That effectively > means, that we have two implementations of the protocol. I don't > think this will improve maintainability, since then bugs needs to > be fixed in two places? Note, that we have a couple of drivers > with serdev+hci_uart by now: > > for file in $(grep -l serdev drivers/bluetooth/hci_*c) ; grep -l hci_uart_register_proto "${file}" > hci_bcm.c > hci_h5.c > hci_ldisc.c > hci_ll.c > hci_mrvl.c > hci_qca.c I would like to have something similar to btmtkuart.c which is a pure serdev driver that doesn’t depend on any hci_ldisc.c framework. If we have this, then we would just drop hci_ll.c from the kernel and focus on the serdev only version. As noted, there is no need for any other driver at that point since everything is probed anyway. Users will not even notice the difference. Regards Marcel