From: Marcel Holtmann <marcel@holtmann.org>
To: Hsin-Yu Chao <hychao@chromium.org>
Cc: linux-bluetooth@vger.kernel.org,
chromeos-bluetooth-upstreaming@chromium.org, alainm@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add SCO fallback for invalid LMP parameters error
Date: Mon, 18 May 2020 10:01:13 +0200 [thread overview]
Message-ID: <B657F91B-0494-4B4C-8DE7-1E9F51085B1B@holtmann.org> (raw)
In-Reply-To: <20200515092704.902-1-hychao@google.com>
Hi Hsin-Yu,
> Bluetooth PTS test case HFP/AG/ACC/BI-12-I accepts SCO connection
> with invalid parameter at the first SCO request expecting AG to
> attempt another SCO request with the use of "safe settings" for
> given codec, base on section 5.7.1.2 of HFP 1.7 specification.
>
> This patch addresses it by adding "Invalid LMP Parameters" (0x1e)
> to the SCO fallback case. Verified with below log:
>
> < HCI Command: Setup Synchronous Connection (0x01|0x0028) plen 17
> Handle: 256
> Transmit bandwidth: 8000
> Receive bandwidth: 8000
> Max latency: 13
> Setting: 0x0003
> Input Coding: Linear
> Input Data Format: 1's complement
> Input Sample Size: 8-bit
> # of bits padding at MSB: 0
> Air Coding Format: Transparent Data
> Retransmission effort: Optimize for link quality (0x02)
> Packet type: 0x0380
> 3-EV3 may not be used
> 2-EV5 may not be used
> 3-EV5 may not be used
>> HCI Event: Command Status (0x0f) plen 4
> Setup Synchronous Connection (0x01|0x0028) ncmd 1
> Status: Success (0x00)
>> HCI Event: Number of Completed Packets (0x13) plen 5
> Num handles: 1
> Handle: 256
> Count: 1
>> HCI Event: Max Slots Change (0x1b) plen 3
> Handle: 256
> Max slots: 1
>> HCI Event: Synchronous Connect Complete (0x2c) plen 17
> Status: Invalid LMP Parameters / Invalid LL Parameters (0x1e)
> Handle: 0
> Address: 00:1B:DC:F2:21:59 (OUI 00-1B-DC)
> Link type: eSCO (0x02)
> Transmission interval: 0x00
> Retransmission window: 0x02
> RX packet length: 0
> TX packet length: 0
> Air mode: Transparent (0x03)
> < HCI Command: Setup Synchronous Connection (0x01|0x0028) plen 17
> Handle: 256
> Transmit bandwidth: 8000
> Receive bandwidth: 8000
> Max latency: 8
> Setting: 0x0003
> Input Coding: Linear
> Input Data Format: 1's complement
> Input Sample Size: 8-bit
> # of bits padding at MSB: 0
> Air Coding Format: Transparent Data
> Retransmission effort: Optimize for link quality (0x02)
> Packet type: 0x03c8
> EV3 may be used
> 2-EV3 may not be used
> 3-EV3 may not be used
> 2-EV5 may not be used
> 3-EV5 may not be used
>> HCI Event: Command Status (0x0f) plen 4
> Setup Synchronous Connection (0x01|0x0028) ncmd 1
> Status: Success (0x00)
>> HCI Event: Max Slots Change (0x1b) plen 3
> Handle: 256
> Max slots: 5
>> HCI Event: Max Slots Change (0x1b) plen 3
> Handle: 256
> Max slots: 1
>> HCI Event: Synchronous Connect Complete (0x2c) plen 17
> Status: Success (0x00)
> Handle: 257
> Address: 00:1B:DC:F2:21:59 (OUI 00-1B-DC)
> Link type: eSCO (0x02)
> Transmission interval: 0x06
> Retransmission window: 0x04
> RX packet length: 30
> TX packet length: 30
> Air mode: Transparent (0x03)
>
> Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
> ---
> net/bluetooth/hci_event.c | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2020-05-18 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 9:27 [PATCH] Bluetooth: Add SCO fallback for invalid LMP parameters error Hsin-Yu Chao
2020-05-18 8:01 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B657F91B-0494-4B4C-8DE7-1E9F51085B1B@holtmann.org \
--to=marcel@holtmann.org \
--cc=alainm@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=hychao@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).