From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C11EFA3728 for ; Wed, 16 Oct 2019 19:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7087C20854 for ; Wed, 16 Oct 2019 19:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436715AbfJPTPG convert rfc822-to-8bit (ORCPT ); Wed, 16 Oct 2019 15:15:06 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:34136 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731321AbfJPTPG (ORCPT ); Wed, 16 Oct 2019 15:15:06 -0400 Received: from surfer-172-29-2-69-hotspot.internet-for-guests.com (p2E5701B0.dip0.t-ipconnect.de [46.87.1.176]) by mail.holtmann.org (Postfix) with ESMTPSA id B5F1BCECDD; Wed, 16 Oct 2019 21:24:02 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\)) Subject: Re: [PATCHv2 4/4] Bluetooth: btwilink: drop superseded driver From: Marcel Holtmann In-Reply-To: <20191003134147.9458-5-sre@kernel.org> Date: Wed, 16 Oct 2019 21:15:03 +0200 Cc: Tony Lindgren , Adam Ford , Enric Balletbo i Serra , linux-bluetooth@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel Content-Transfer-Encoding: 8BIT Message-Id: References: <20191003134147.9458-1-sre@kernel.org> <20191003134147.9458-5-sre@kernel.org> To: Sebastian Reichel X-Mailer: Apple Mail (2.3594.4.19) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Sebastian, > All users of this driver have been converted to the serdev based > hci_ll driver. The unused driver can be safely dropped now. > > Signed-off-by: Sebastian Reichel > --- > drivers/bluetooth/Kconfig | 11 -- > drivers/bluetooth/Makefile | 1 - > drivers/bluetooth/btwilink.c | 337 ----------------------------------- > 3 files changed, 349 deletions(-) > delete mode 100644 drivers/bluetooth/btwilink.c patch has been applied to bluetooth-next tree. However what I really like to see is that you re-introduce a btwilink driver that is purely serdev based and doesn’t rely on any hci_uart/hci_ldisc code. A clean serdev only driver is that best and easier to maintain long term. Regards Marcel