Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] build: Add an option to explicitly disable installing hid2hci
@ 2020-05-06  0:55 Sonny Sasaka
  2020-05-06 11:06 ` Marcel Holtmann
  2020-05-13  8:02 ` Marcel Holtmann
  0 siblings, 2 replies; 8+ messages in thread
From: Sonny Sasaka @ 2020-05-06  0:55 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Sonny Sasaka

---
 configure.ac | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 1433ace4a..ba9937a16 100644
--- a/configure.ac
+++ b/configure.ac
@@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
 fi
 AC_SUBST(UDEV_DIR, [${path_udevdir}])
 
+AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
+		[disable hid2hci tool]), [enable_hid2hci=${enableval}])
 AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
-						test "${enable_udev}" != "no")
+					test "${enable_udev}" != "no" &&
+					test "${enable_hid2hci}" != "no")
 
 AC_ARG_ENABLE(cups, AC_HELP_STRING([--disable-cups],
                 [disable CUPS printer support]), [enable_cups=${enableval}])
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
  2020-05-06  0:55 [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka
@ 2020-05-06 11:06 ` Marcel Holtmann
  2020-05-06 17:05   ` Sonny Sasaka
  2020-05-13  8:02 ` Marcel Holtmann
  1 sibling, 1 reply; 8+ messages in thread
From: Marcel Holtmann @ 2020-05-06 11:06 UTC (permalink / raw)
  To: Sonny Sasaka; +Cc: linux-bluetooth

Hi Sonny,

> ---
> configure.ac | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1433ace4a..ba9937a16 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> fi
> AC_SUBST(UDEV_DIR, [${path_udevdir}])
> 
> +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> +		[disable hid2hci tool]), [enable_hid2hci=${enableval}])
> AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> -						test "${enable_udev}" != "no")
> +					test "${enable_udev}" != "no" &&
> +					test "${enable_hid2hci}" != "no")

can you give me a bit of background why you need that. We did have that and I removed it in favor of putting everything behind udev. Mainly since we really don’t need most of these things anymore. Can’t you just disable udev support and get the same result?

Regards

Marcel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
  2020-05-06 11:06 ` Marcel Holtmann
@ 2020-05-06 17:05   ` Sonny Sasaka
  2020-05-12 21:19     ` Sonny Sasaka
  0 siblings, 1 reply; 8+ messages in thread
From: Sonny Sasaka @ 2020-05-06 17:05 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: BlueZ

Hi Marcel,

Chrome OS doesn't support HID-HCI switchable controllers so we would
like to remove this from being installed to reduce maintenance burden.
Disabling udev unfortunately also uninstalls sixaxis plugin, which we
still need. Do you have a suggestion how we can achieve this?

On Wed, May 6, 2020 at 4:06 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > ---
> > configure.ac | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..ba9937a16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> > fi
> > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> >
> > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > +             [disable hid2hci tool]), [enable_hid2hci=${enableval}])
> > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> > -                                             test "${enable_udev}" != "no")
> > +                                     test "${enable_udev}" != "no" &&
> > +                                     test "${enable_hid2hci}" != "no")
>
> can you give me a bit of background why you need that. We did have that and I removed it in favor of putting everything behind udev. Mainly since we really don’t need most of these things anymore. Can’t you just disable udev support and get the same result?
>
> Regards
>
> Marcel
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
  2020-05-06 17:05   ` Sonny Sasaka
@ 2020-05-12 21:19     ` Sonny Sasaka
  0 siblings, 0 replies; 8+ messages in thread
From: Sonny Sasaka @ 2020-05-12 21:19 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: BlueZ

Hi Marcel,

Could you please take another look at this patch? Thanks!

On Wed, May 6, 2020 at 10:05 AM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
>
> Hi Marcel,
>
> Chrome OS doesn't support HID-HCI switchable controllers so we would
> like to remove this from being installed to reduce maintenance burden.
> Disabling udev unfortunately also uninstalls sixaxis plugin, which we
> still need. Do you have a suggestion how we can achieve this?
>
> On Wed, May 6, 2020 at 4:06 AM Marcel Holtmann <marcel@holtmann.org> wrote:
> >
> > Hi Sonny,
> >
> > > ---
> > > configure.ac | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index 1433ace4a..ba9937a16 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> > > fi
> > > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> > >
> > > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > > +             [disable hid2hci tool]), [enable_hid2hci=${enableval}])
> > > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> > > -                                             test "${enable_udev}" != "no")
> > > +                                     test "${enable_udev}" != "no" &&
> > > +                                     test "${enable_hid2hci}" != "no")
> >
> > can you give me a bit of background why you need that. We did have that and I removed it in favor of putting everything behind udev. Mainly since we really don’t need most of these things anymore. Can’t you just disable udev support and get the same result?
> >
> > Regards
> >
> > Marcel
> >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
  2020-05-06  0:55 [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka
  2020-05-06 11:06 ` Marcel Holtmann
@ 2020-05-13  8:02 ` Marcel Holtmann
  2020-05-13 21:38   ` [PATCH v2] build: Add an option to explicitly enable hid2hci Sonny Sasaka
  2020-05-13 21:41   ` [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka
  1 sibling, 2 replies; 8+ messages in thread
From: Marcel Holtmann @ 2020-05-13  8:02 UTC (permalink / raw)
  To: Sonny Sasaka; +Cc: linux-bluetooth

Hi Sonny,

> ---
> configure.ac | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1433ace4a..ba9937a16 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> fi
> AC_SUBST(UDEV_DIR, [${path_udevdir}])
> 
> +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> +		[disable hid2hci tool]), [enable_hid2hci=${enableval}])
> AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> -						test "${enable_udev}" != "no")
> +					test "${enable_udev}" != "no" &&
> +					test "${enable_hid2hci}" != "no")

I looked at this again. Lets turn this around and make this an --enable-hid2hci similar to --enable-sixaxis.

And you need to change the ${enable_tools} into ${enable_hid2hci} actually and not just add another dependency. Everything else seems to be already in the Makefile.tools for this.

Regards

Marcel


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] build: Add an option to explicitly enable hid2hci
  2020-05-13  8:02 ` Marcel Holtmann
@ 2020-05-13 21:38   ` Sonny Sasaka
  2020-05-18  7:53     ` Marcel Holtmann
  2020-05-13 21:41   ` [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka
  1 sibling, 1 reply; 8+ messages in thread
From: Sonny Sasaka @ 2020-05-13 21:38 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Sonny Sasaka

hid2hci is no longer a common use. This patch changes the default to not
build and install hid2hci and provide a configure flag --enable-hid2hci
to explicitly enable it.
---
 configure.ac | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 1433ace4a..e1c8fd9ad 100644
--- a/configure.ac
+++ b/configure.ac
@@ -218,7 +218,9 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
 fi
 AC_SUBST(UDEV_DIR, [${path_udevdir}])
 
-AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
+AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--enable-hid2hci],
+		[enable hid2hci tool]), [enable_hid2hci=${enableval}])
+AM_CONDITIONAL(HID2HCI, test "${enable_hid2hci}" = "yes" &&
 						test "${enable_udev}" != "no")
 
 AC_ARG_ENABLE(cups, AC_HELP_STRING([--disable-cups],
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
  2020-05-13  8:02 ` Marcel Holtmann
  2020-05-13 21:38   ` [PATCH v2] build: Add an option to explicitly enable hid2hci Sonny Sasaka
@ 2020-05-13 21:41   ` Sonny Sasaka
  1 sibling, 0 replies; 8+ messages in thread
From: Sonny Sasaka @ 2020-05-13 21:41 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: BlueZ

Thanks for the suggestion, Marcel. I have sent the v2 patch, please
take another look. Thanks.

On Wed, May 13, 2020 at 1:02 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > ---
> > configure.ac | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..ba9937a16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> > fi
> > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> >
> > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > +             [disable hid2hci tool]), [enable_hid2hci=${enableval}])
> > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> > -                                             test "${enable_udev}" != "no")
> > +                                     test "${enable_udev}" != "no" &&
> > +                                     test "${enable_hid2hci}" != "no")
>
> I looked at this again. Lets turn this around and make this an --enable-hid2hci similar to --enable-sixaxis.
>
> And you need to change the ${enable_tools} into ${enable_hid2hci} actually and not just add another dependency. Everything else seems to be already in the Makefile.tools for this.
>
> Regards
>
> Marcel
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] build: Add an option to explicitly enable hid2hci
  2020-05-13 21:38   ` [PATCH v2] build: Add an option to explicitly enable hid2hci Sonny Sasaka
@ 2020-05-18  7:53     ` Marcel Holtmann
  0 siblings, 0 replies; 8+ messages in thread
From: Marcel Holtmann @ 2020-05-18  7:53 UTC (permalink / raw)
  To: Sonny Sasaka; +Cc: linux-bluetooth

Hi Sonny,

> hid2hci is no longer a common use. This patch changes the default to not
> build and install hid2hci and provide a configure flag --enable-hid2hci
> to explicitly enable it.
> ---
> configure.ac | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

patch has been applied.

Regards

Marcel


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  0:55 [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka
2020-05-06 11:06 ` Marcel Holtmann
2020-05-06 17:05   ` Sonny Sasaka
2020-05-12 21:19     ` Sonny Sasaka
2020-05-13  8:02 ` Marcel Holtmann
2020-05-13 21:38   ` [PATCH v2] build: Add an option to explicitly enable hid2hci Sonny Sasaka
2020-05-18  7:53     ` Marcel Holtmann
2020-05-13 21:41   ` [PATCH] build: Add an option to explicitly disable installing hid2hci Sonny Sasaka

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git