From: Marcel Holtmann <marcel@holtmann.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linma <linma@zju.edu.cn>, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Hao Xiong <mart1n@zju.edu.cn>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: fix the erroneous flush_work() order
Date: Thu, 27 May 2021 22:14:59 +0200 [thread overview]
Message-ID: <BF0493D4-AB96-44D3-8229-9EA6D084D260@holtmann.org> (raw)
In-Reply-To: <20210525123902.189012-1-gregkh@linuxfoundation.org>
Hi Greg,
> In the cleanup routine for failed initialization of HCI device,
> the flush_work(&hdev->rx_work) need to be finished before the
> flush_work(&hdev->cmd_work). Otherwise, the hci_rx_work() can
> possibly invoke new cmd_work and cause a bug, like double free,
> in late processings.
>
> This was assigned CVE-2021-3564.
>
> This patch reorder the flush_work() to fix this bug.
>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>
> Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-bluetooth@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
> Signed-off-by: Hao Xiong <mart1n@zju.edu.cn>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> net/bluetooth/hci_core.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-stable tree.
Regards
Marcel
next prev parent reply other threads:[~2021-05-27 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 12:39 [PATCH v2] Bluetooth: fix the erroneous flush_work() order Greg Kroah-Hartman
2021-05-25 13:36 ` [v2] " bluez.test.bot
2021-05-25 14:21 ` Greg KH
2021-05-25 18:16 ` Luiz Augusto von Dentz
2021-05-27 20:14 ` Marcel Holtmann [this message]
2021-06-08 4:53 ` [PATCH v2] " Salvatore Bonaccorso
2021-06-08 8:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF0493D4-AB96-44D3-8229-9EA6D084D260@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mart1n@zju.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).