linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Alain Michaud <alainm@chromium.org>
Cc: Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
	Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
	Yu Liu <yudiliu@google.com>
Subject: Re: [PATCH v2] Bluetooth: use the proper scan params when conn is pending
Date: Fri, 31 Jul 2020 08:29:41 +0200	[thread overview]
Message-ID: <C43B1571-6221-4D1A-A4F7-E211FE69F499@holtmann.org> (raw)
In-Reply-To: <20200731010535.1422455-1-alainm@chromium.org>

Hi Alain,

> When an LE connection is requested and an RPA update is needed via
> hci_connect_le_scan, the default scanning parameters are used rather
> than the connect parameters.  This leads to significant delays in the
> connection establishment process when using lower duty cycle scanning
> parameters.
> 
> The patch simply looks at the pended connection list when trying to
> determine which scanning parameters should be used.
> 
> Before:
> < HCI Command: LE Set Extended Scan Parameters (0x08|0x0041) plen 8
>                             #378 [hci0] 1659.247156
>         Own address type: Public (0x00)
>         Filter policy: Ignore not in white list (0x01)
>         PHYs: 0x01
>         Entry 0: LE 1M
>           Type: Passive (0x00)
>           Interval: 367.500 msec (0x024c)
>           Window: 37.500 msec (0x003c)
> 
> After:
> < HCI Command: LE Set Extended Scan Parameters (0x08|0x0041) plen 8
>                                #39 [hci0] 7.422109
>         Own address type: Public (0x00)
>         Filter policy: Ignore not in white list (0x01)
>         PHYs: 0x01
>         Entry 0: LE 1M
>           Type: Passive (0x00)
>           Interval: 60.000 msec (0x0060)
>           Window: 60.000 msec (0x0060)
> 
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Reviewed-by: Yu Liu <yudiliu@google.com>
> Signed-off-by: Alain Michaud <alainm@chromium.org>

please swap these around, the signed-off-by from the author should come first.

> 
> ---
> 
> Changes in v2:
> - Fixing Yu's email tag
> 
> net/bluetooth/hci_request.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)

Patch has been applied to bluetooth-next tree.

Regards

Marcel


      reply	other threads:[~2020-07-31  6:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  1:05 [PATCH v2] Bluetooth: use the proper scan params when conn is pending Alain Michaud
2020-07-31  6:29 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C43B1571-6221-4D1A-A4F7-E211FE69F499@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=abhishekpandit@chromium.org \
    --cc=alainm@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=yudiliu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).