From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCACC7618B for ; Wed, 24 Jul 2019 09:37:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2B5B229F3 for ; Wed, 24 Jul 2019 09:37:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJJl9FW/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbfGXJh5 (ORCPT ); Wed, 24 Jul 2019 05:37:57 -0400 Received: from mail-yw1-f41.google.com ([209.85.161.41]:46478 "EHLO mail-yw1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbfGXJh5 (ORCPT ); Wed, 24 Jul 2019 05:37:57 -0400 Received: by mail-yw1-f41.google.com with SMTP id z197so17892849ywd.13 for ; Wed, 24 Jul 2019 02:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vxFNjo2EEh4PCrV0gRkp8rJ6Nde2pYDP4iIWI4Yf/HU=; b=cJJl9FW/VoH5y0oR3NdSMy4MpURyFvLx1ZZPthFYQTZf7GKCaZK2Zc9oOENA1gA54Z +Q7PcA7cNKWJ8C26s6a9PQ2oBUdjBq9K6embYdBs72/ECPr9UH7NxgBR71ibWdZAYKHH o5Z9F+PlKzKMTN+fWvR0FJMXTfRSKLdww+LMx/gqLIDfFAwiQN+JHLvc0AXk9QB/03Yf lWm3+E5+GWd68ZcQ5cu/Sz2GkHHS+eSqm+zFs8GHN7U8fJYA4AZI68SwPgU42Unrsyc8 wPzpB5Fk6MKVe3n5GSJflSKYF+DtBZ2GsapG0iSn0t/T+sY07iMTtkp0eyb15/fPjhGs ToWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=vxFNjo2EEh4PCrV0gRkp8rJ6Nde2pYDP4iIWI4Yf/HU=; b=XM1eMC5MUnJaqjY0ecHgjUlpedZym1PjWLzYRTLBiylxYfhGLl7dlr4CTFaG+Kuury LLDe4W4FjmAFcKdfX2+aX3KhJOKoAttwOlv7xui7x2raUwHqp9cxSR5A78qODtOyO1Wo j/7HTKxCDm/yy7n8UPcZ3qcGTRWAaq9s0iYS4jnweuPFfKks7FCxvQxBYTZmtIu3k8U+ aWMO/5qeb9/CdnUYh72gLP9ANcRU7D8BBh6ml7qsHJ3z+aT7A9+5pTvQsDetFCB0Pr4F bUbJ1rdAcKGjZoZSt/xSCpvuxsPMtBJbmWX8Fd97Hkd86qqm8aLOk9lgrflKYJ89vzzI gbkw== X-Gm-Message-State: APjAAAVO6Jaj2RgtPQIphKL5TJIk9Pdq5GYcn3Y55g6yZ/LcYHgKbn/a V1fnGPNhUaxsPiI9HHlEQYKd/lDgvQVg9pARCAmE2SuT X-Google-Smtp-Source: APXvYqxnhzdd30cG9/oWbibfcDWm0sJOx0y1cBRASOLV3MuBJrToTM6FZ42VVCMEVLAU14LUoOCDTQNW98U1ndB8Z2k= X-Received: by 2002:a81:840f:: with SMTP id u15mr47684824ywf.505.1563961075589; Wed, 24 Jul 2019 02:37:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Barry Byford <31baz66@gmail.com> Date: Wed, 24 Jul 2019 10:37:44 +0100 Message-ID: Subject: Re: DBus LEAdvertisement and Python To: Bluez mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org I have exhausted my ideas for debugging this issue. Using d-feet and various other utilities the creation of the beacon using python-dbus and pydbus looks identical. However, BlueZ doesn't seem to be able to parse the properties from LEAdvertisement1 when it is created with pydbus. It would be great if anyone has any ideas for what else to try. Have people had similar issues using DBus libraries in other languages? For reference, I have installed pydbus with "sudo pip3 install pydbus" I am running with BlueZ 5.50. The test code I am using is: import pydbus from gi.repository import GLib class Advertisement: """ """ LE_ADVERTISEMENT_IFACE = 'org.bluez.LEAdvertisement1' def Release(self): pass @property def Type(self): return 'broadcast' @property def SolicitUUIDs(self): return [] @property def ServiceUUIDs(self): return ['FEAA'] @property def ServiceData(self): return {'FEAA': GLib.Variant('ay', [0x10, 0x08, 0x03, 0x75, 0x6B, 0x42, 0x61, 0x7A, 0x2e, 0x67, 0x69, 0x74, 0x68, 0x75, 0x62, 0x2E, 0x69, 0x6F])} @property def IncludeTxPower(self): return False @property def ManufacturerData(self): return [] class LEAdvertisement: def __init__(self, service, object_path): bus = pydbus.SystemBus() bname = bus.request_name(service) reg1 = bus.register_object(object_path, Advertisement(), None) class LEAdvertisingManager: def __init__(self, object_path): lea_iface = 'org.bluez.LEAdvertisingManager1' bus = pydbus.SystemBus() ad_manager = bus.get('org.bluez', '/org/bluez/hci0')[lea_iface] ad_manager.RegisterAdvertisement(object_path, {}) if __name__ == '__main__': app_name = 'ukBaz.bluezero' app_path = '/ukBaz/bluezero/advertisement0099' LEAdvertisement(app_name, app_path) LEAdvertisingManager(app_path) loop = GLib.MainLoop() try: loop.run() except KeyboardInterrupt: print("\nStopping ...") loop.quit() I have the following config to open the permissions up for this service name: $ more /etc/dbus-1/system.d/ukBaz.bluezero.conf Feedback welcome. Cheers, Barry On Sat, 20 Jul 2019 at 17:44, Barry Byford <31baz66@gmail.com> wrote: > > Hello, > > I have done a little more investigation on this. The difference in > behaviour between the working library and the failing library comes > down to this line in the BlueZ source. > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/gdbus/client.c#n720 > which is called from: > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/src/advertising.c#n1020 > It appears g_hash_table_lookup is returning NULL. > I am not familiar with C and have been doing this investigation with > fprintf statements. I don't know how to get the values of > "proxy->prop_list" and "name". Does anyone know how I can print these > values out? > Even better would be, if someone could point me at to what this > relates to in the Python LE Advertisement setup through DBus. > I've looked up the g_hash_table_lookup command: > https://developer.gnome.org/glib/stable/glib-Hash-Tables.html#g-hash-table-lookup > but this hasn't helped me. > > Thanks, > Barry > > On Thu, 18 Jul 2019 at 22:04, Barry Byford <31baz66@gmail.com> wrote: > > > > Hello Luiz, > > > > Thanks for the prompt response. Below are some updates following your input. > > > > On Thu, 18 Jul 2019 at 09:26, Luiz Augusto von Dentz > > wrote: > > > > > > Hi Barry, > > > > > > On Thu, Jul 18, 2019 at 10:03 AM Barry Byford <31baz66@gmail.com> wrote: > > > > > > > > Hello, > > > > > > > > The Python examples provided in the test directory of the BlueZ > > > > repository use the python-dbus library. Looking at the documentation > > > > of that library it does start by raising concerns and offering > > > > alternatives. I have been looking at some of the alternatives and am > > > > having difficultly getting them to work with BlueZ. I have been > > > > focusing on the org.bluez.LEAdvertisement1 interface. > > > > > > > > Looking at the documentation, it says the service, interface and > > > > object details are: > > > > Service org.bluez > > > > Interface org.bluez.LEAdvertisement1 > > > > Object path freely definable > > > > > > > > I am not being successful at publishing to the org.bluez service. It > > > > is also not where the current examples publish to. > > > > Looking at the GattProfile1 documentation, it has service and object > > > > as application dependant. > > > > Service > > > > Interface org.bluez.GattProfile1 > > > > Object path > > > > Should the documentation of Service on LEAdvertisement1 be freely > > > > definable also? > > > > > > Yep, the bus name is up to the application which usually don't > > > register a friendly name if you try to register with 'org.bluez' it > > > would probably conflict with the daemon itself so you wouldn't be able > > > to register that name anyway. > > > > > > > I have created the LEAdvertisement1 interface so that it has an > > > > ObjectManager and is introspectable. When I pass the object to > > > > RegisterAdvertisement on the org.bluez.LEAdvertisingManager1 interface > > > > it accepts it (does not give an error) but does not register the data > > > > and I see no advertisement appear. Is there somewhere I can find a > > > > more detailed description of what needs to be on the > > > > org.bluez.LEAdvertisement1 interface that will work with > > > > RegisterAdvertisement? > > > > > > Do you have the bluetoothd output when you register, I get the > > > following when using bluetoothctl: > > > > > > bluetooth]# power on > > > Changing power on succeeded > > > [bluetooth]# advertise on > > > [CHG] Controller B8:8A:60:D8:17:D7 SupportedInstances: 0x04 > > > [CHG] Controller B8:8A:60:D8:17:D7 ActiveInstances: 0x01 > > > Advertising object registered > > > Tx Power: off > > > Name: off > > > Apperance: off > > > Discoverable: off > > > [bluetooth]# > > > > Using the new dbus library I get: > > Log from bluetoothctl: > > [CHG] Controller FC:F8:AE:8F:0C:A4 SupportedInstances: 0x04 > > [CHG] Controller FC:F8:AE:8F:0C:A4 ActiveInstances: 0x01 > > > > From the bluetoothd log: > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > RegisterAdvertisement > > bluetoothd[2856]: src/advertising.c:client_create() Adding proxy for > > /ukBaz/bluezero/advertisement1 > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > Registered advertisement at path /ukBaz/bluezero/advertisement1 > > bluetoothd[2856]: src/advertising.c:refresh_adv() Refreshing > > advertisement: /ukBaz/bluezero/advertisement1 > > bluetoothd[2856]: src/advertising.c:add_adv_callback() Advertisement > > registered: /ukBaz/bluezero/advertisement1 > > > > > > With the old pyton-dbus library (that is working) I get: > > log from bluetoothctl: > > [CHG] Controller FC:F8:AE:8F:0C:A4 SupportedInstances: 0x04 > > [CHG] Controller FC:F8:AE:8F:0C:A4 ActiveInstances: 0x01 > > > > From the bluetoothd log: > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > RegisterAdvertisement > > bluetoothd[2856]: src/advertising.c:client_create() Adding proxy for > > /ukBaz/bluezero/advertisement0001 > > bluetoothd[2856]: src/advertising.c:register_advertisement() > > Registered advertisement at path /ukBaz/bluezero/advertisement0001 > > bluetoothd[2856]: src/advertising.c:parse_service_uuids() Adding > > ServiceUUID: FEAA > > bluetoothd[2856]: src/advertising.c:parse_service_data() Adding > > ServiceData for FEAA > > bluetoothd[2856]: src/advertising.c:refresh_adv() Refreshing > > advertisement: /ukBaz/bluezero/advertisement0001 > > bluetoothd[2856]: src/advertising.c:add_adv_callback() Advertisement > > registered: /ukBaz/bluezero/advertisement0001 > > > > > > > > > > bluetoothd[6103]: src/advertising.c:client_create() Adding proxy for > > > /org/bluez/advertising > > > bluetoothd[6103]: src/advertising.c:register_advertisement() > > > Registered advertisement at path /org/bluez/advertising > > > bluetoothd[6103]: src/advertising.c:refresh_adv() Refreshing > > > advertisement: /org/bluez/advertising > > > bluetoothd[6103]: src/advertising.c:add_adv_callback() Advertisement > > > registered: /org/bluez/advertising > > > > > > > > > > For reference, I have put below what I am currently putting on the > > > > org.bluez.LEAdvertisement1 interface. > > > > > > > > Thanks, > > > > Barry > > > > > > > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > org.freedesktop.DBus.ObjectManager GetManagedObjects > > > > a{oa{sa{sv}}} 1 "/ukBaz/bluezero/advertisement1" 5 > > > > "org.freedesktop.DBus.Properties" 0 > > > > "org.freedesktop.DBus.Introspectable" 0 "org.freedesktop.DBus.Peer" 0 > > > > "org.freedesktop.DBus.ObjectManager" 0 "org.bluez.LEAdvertisement1" 6 > > > > "Type" s "broadcast" "ServiceUUIDs" as 0 "ManufacturerData" a{sv} 0 > > > > "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 "FEAA" ay 18 16 8 3 117 107 > > > > 66 97 122 46 103 105 116 104 117 98 46 105 111 "IncludeTxPower" b > > > > false > > > > > > Not sure if that is the problem but usually ObjectManager is suppose > > > to be on the '/' (root) path. > > > > Good point. It is not clear (to me anyway) exactly what the > > requirement is from reading the spec > > https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager > > I have moved the object manager to the root (/) but this does not seem > > to have changed anything. > > > > $ busctl call ukBaz.bluezero / org.freedesktop.DBus.ObjectManager > > GetManagedObjects > > a{oa{sa{sv}}} 1 "/ukBaz/bluezero/advertisement1" 4 > > "org.freedesktop.DBus.Properties" 0 > > "org.freedesktop.DBus.Introspectable" 0 "org.freedesktop.DBus.Peer" 0 > > "org.bluez.LEAdvertisement1" 6 "Type" s "broadcast" "ServiceUUIDs" as > > 0 "ManufacturerData" a{sv} 0 "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 > > "FEAA" ay 18 16 8 3 117 107 66 97 122 46 103 105 116 104 117 98 46 105 > > 111 "IncludeTxPower" b false > > > > > > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > org.freedesktop.DBus.Properties GetAll s org.bluez.LEAdvertisement1 > > > > a{sv} 6 "Type" s "broadcast" "ServiceUUIDs" as 0 "ManufacturerData" > > > > a{sv} 0 "SolicitUUIDs" as 0 "ServiceData" a{sv} 1 "FEAA" ay 18 16 8 3 > > > > 117 107 66 97 122 46 103 105 116 104 117 98 46 105 111 > > > > "IncludeTxPower" b false > > > > > > > > Using the d-feet application I did a GetAll on the advertisements and > > the data looks identical for both > > Using the new DBus library: > > {'IncludeTxPower': False, > > 'ManufacturerData': {}, > > 'ServiceData': {'FEAA': [16, > > 8, > > 3, > > 117, > > 107, > > 66, > > 97, > > 122, > > 46, > > 103, > > 105, > > 116, > > 104, > > 117, > > 98, > > 46, > > 105, > > 111]}, > > 'ServiceUUIDs': ['FEAA'], > > 'SolicitUUIDs': [], > > 'Type': 'broadcast'} > > > > Using the old Python-dbus library: > > {'IncludeTxPower': False, > > 'ServiceData': {'FEAA': [16, > > 8, > > 3, > > 117, > > 107, > > 66, > > 97, > > 122, > > 46, > > 103, > > 105, > > 116, > > 104, > > 117, > > 98, > > 46, > > 105, > > 111]}, > > 'ServiceUUIDs': ['FEAA'], > > 'Type': 'broadcast'} > > > > > > $ busctl call ukBaz.bluezero /ukBaz/bluezero/advertisement1 > > > > org.freedesktop.DBus.Introspectable Introspect > > > > s " > > > Introspection 1.0//EN\"\n > > > > \"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd\">\n\n\n > > > name=\"org.freedesktop.DBus.Properties\">\n \n > > > > \n > > > > \n > > > type=\"v\" name=\"value\" direction=\"out\"/>\n \n > > > > \n > > > name=\"interface_name\" direction=\"in\"/>\n > > > name=\"properties\" direction=\"out\"/>\n \n > > > name=\"Set\">\n > > > direction=\"in\"/>\n > > > direction=\"in\"/>\n > > > direction=\"in\"/>\n \n > > > name=\"PropertiesChanged\">\n > > > name=\"interface_name\"/>\n > > > name=\"changed_properties\"/>\n > > > name=\"invalidated_properties\"/>\n \n \n > > > > \n > > > name=\"Introspect\">\n > > > direction=\"out\"/>\n \n \n > > > name=\"org.freedesktop.DBus.Peer\">\n \n > > > > \n > > > name=\"machine_uuid\" direction=\"out\"/>\n \n > > > > \n > > > name=\"org.freedesktop.DBus.ObjectManager\">\n > > > name=\"GetManagedObjects\">\n > > > name=\"object_paths_interfaces_and_properties\" direction=\"out\">\n > > > > \n \n \n > > > > \n \n > > > type=\"a{sa{sv}}\" name=\"interfaces_and_properties\">\n \n > > > > \n \n > > > type=\"o\" name=\"object_path\">\n \n > > > name=\"interfaces\">\n \n \n \n > > > > \n > > > name=\"org.freedesktop.DBus.Properties.PropertiesChanged\" > > > > value=\"const\">\n \n \n > > > > > > > value=\"true\">\n \n \n > > > type=\"s\" name=\"Type\" access=\"read\">\n \n > > > > \n > > > > \n > > > access=\"read\">\n \n > > > name=\"SolicitUUIDs\" access=\"read\">\n \n > > > type=\"a{sv}\" name=\"ServiceData\" access=\"read\">\n > > > > \n > > > access=\"read\">\n \n \n\n" > > > > > > > > > > > > -- > > > Luiz Augusto von Dentz