linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Barry Byford <31baz66@gmail.com>
To: wangyouwan <wangyouwan@uniontech.com>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
Date: Thu, 22 Jul 2021 08:07:08 +0100	[thread overview]
Message-ID: <CAAu3APbE1jQSC_zPzXDYQcuMJqoKQ3cbApQt5sJ6M_6ZDWQ4Jg@mail.gmail.com> (raw)
In-Reply-To: <20210722021952.18260-1-wangyouwan@uniontech.com>

On Thu, 22 Jul 2021 at 03:23, wangyouwan <wangyouwan@uniontech.com> wrote:
>
>     I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
>

There is now Core V5.3 which has been updated to use inclusive
language as outlined by Archie in his post:

https://marc.info/?l=linux-bluetooth&m=162195325125419&w=2

I think the terms should be Central or Peripheral. Here is the same
extract from the spec in v5.3

8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a Peripheral
when joining an existing piconet, since by definition the paging device is
initially Central of a piconet involving the pager (Central) and the paged
(Peripheral) device.
• A role switch is necessary in order for a Peripheral in an existing piconet to
set up a new piconet with itself as Central and the original piconet Central as
Peripheral. If the original piconet had more than one Peripheral, then this
implies a double role for the original piconet Central; it becomes a Peripheral
in the new piconet while still maintaining the original piconet as Central.

>     8.6.5 Role switch
>     There are several occasions when a role switch is used:
>     • A role switch is necessary in order to make a paging device a slave when
>     joining an existing piconet, since by definition the paging device is initially
>     master of a piconet involving the pager (master) and the paged (slave)
>     device.
>     • A role switch is necessary in order for a slave in an existing piconet to set up
>     a new piconet with itself as master and the original piconet master as slave.
>     If the original piconet had more than one slave, then this implies a double
>     role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
> ---
>  monitor/packet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
>                 str = "Stay master";
>                 break;
>         case 0x01:
> -               str = "Allow slave";
> +               str = "Master Or Slave";
>                 break;
>         default:
>                 str = "Reserved";
> --
> 2.20.1
>
>
>

  parent reply	other threads:[~2021-07-22  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  2:19 wangyouwan
2021-07-22  3:02 ` bluez.test.bot
2021-07-22  7:07 ` Barry Byford [this message]
2021-07-22 14:47 ` [PATCH] " Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAu3APbE1jQSC_zPzXDYQcuMJqoKQ3cbApQt5sJ6M_6ZDWQ4Jg@mail.gmail.com \
    --to=31baz66@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=wangyouwan@uniontech.com \
    --subject='Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).