From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/2] build: Fix missing dependency for btpclient
Date: Wed, 13 Feb 2019 17:20:17 +0200 [thread overview]
Message-ID: <CABBYNZ+ETBN2zkAaOgNo6MocY27eH+Lw24qysyNJUpCKYVbc2w@mail.gmail.com> (raw)
In-Reply-To: <20190212151515.13436-1-szymon.janc@codecoup.pl>
Hi Szymon,
On Tue, Feb 12, 2019 at 5:18 PM Szymon Janc <szymon.janc@codecoup.pl> wrote:
>
> prog_DEPENDENCIES is computed by automake only if not supplied so we
> must provide all dependencies if provided manually.
>
> This resulted in random build failures:
>
> libtool: error: cannot find the library 'lib/libbluetooth-internal.la'
> or unhandled argument 'lib/libbluetooth-internal.la'
> make[1]: *** [Makefile:5436: tools/btpclient] Error 1
> ---
> Makefile.tools | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.tools b/Makefile.tools
> index 1f8271542..0f94bbbe7 100644
> --- a/Makefile.tools
> +++ b/Makefile.tools
> @@ -471,5 +471,5 @@ noinst_PROGRAMS += tools/btpclient
> tools_btpclient_SOURCES = tools/btpclient.c src/shared/btp.c src/shared/btp.h
> tools_btpclient_LDADD = lib/libbluetooth-internal.la \
> src/libshared-ell.la $(ell_ldadd)
> -tools_btpclient_DEPENDENCIES = $(ell_dependencies)
> +tools_btpclient_DEPENDENCIES = lib/libbluetooth-internal.la $(ell_dependencies)
> endif
> --
> 2.20.1
Applied.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2019-02-13 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 15:15 [PATCH 1/2] build: Fix missing dependency for btpclient Szymon Janc
2019-02-12 15:15 ` [PATCH 2/2] gitignore: Fix bluetooth-meshd name Szymon Janc
2019-02-13 15:20 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZ+ETBN2zkAaOgNo6MocY27eH+Lw24qysyNJUpCKYVbc2w@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).