From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Manish Mandlik <mmandlik@google.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
Miao-chen Chou <mcchou@google.com>,
Alain Michaud <alainmichaud@google.com>
Subject: Re: [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match
Date: Thu, 24 Jun 2021 13:12:55 -0700 [thread overview]
Message-ID: <CABBYNZ+aN7+M7Tk36MJewcNMwaTdjBMKuz1LX-Q9J-a864XTAQ@mail.gmail.com> (raw)
In-Reply-To: <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
Hi Manish,
On Thu, Jun 24, 2021 at 10:10 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Friendly reminder to review this patch.
>
> Regards,
> Manish.
>
>
> On Thu, Jun 17, 2021 at 9:58 PM Manish Mandlik <mmandlik@google.com> wrote:
>>
>> Do no skip a non-discoverable device if it matches any Advertisement
>> Monitor.
>>
>> Reviewed-by: mcchou@google.com
>> Reviewed-by: alainmichaud@google.com
>> Signed-off-by: Manish Mandlik <mmandlik@google.com>
>> ---
>>
>> src/adapter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 98fc78f1e..2175120f4 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
>>
>> dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
>> if (!dev) {
>> - if (!discoverable) {
>> + if (!discoverable && !matched_monitors) {
>> eir_data_free(&eir_data);
>> return;
>> }
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>
Applied, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2021-06-24 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 4:58 [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match Manish Mandlik
2021-06-18 5:40 ` [BlueZ,v1] " bluez.test.bot
[not found] ` <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
2021-06-24 20:12 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZ+aN7+M7Tk36MJewcNMwaTdjBMKuz1LX-Q9J-a864XTAQ@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=alainmichaud@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcchou@google.com \
--cc=mmandlik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).