Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation
@ 2019-10-08 10:01 Ross Burton
  2019-10-09 15:01 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2019-10-08 10:01 UTC (permalink / raw)
  To: linux-bluetooth

In parallel out-of-tree builds it's possible that tools/*.rules are
generated before the target directory has been implicitly created. Solve this by
creating the directory before writing into it.
---
 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 2ac28b23d..e7bcd2366 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -589,6 +589,7 @@ src/builtin.h: src/genbuiltin $(builtin_sources)
 	$(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@
 
 tools/%.rules:
+	$(AM_V_at)$(MKDIR_P) tools
 	$(AM_V_GEN)cp $(srcdir)/$(subst 97-,,$@) $@
 
 $(lib_libbluetooth_la_OBJECTS): $(local_headers)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation
  2019-10-08 10:01 [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation Ross Burton
@ 2019-10-09 15:01 ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2019-10-09 15:01 UTC (permalink / raw)
  To: Ross Burton; +Cc: linux-bluetooth

Hi Ross,

On Tue, Oct 8, 2019 at 1:04 PM Ross Burton <ross.burton@intel.com> wrote:
>
> In parallel out-of-tree builds it's possible that tools/*.rules are
> generated before the target directory has been implicitly created. Solve this by
> creating the directory before writing into it.
> ---
>  Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 2ac28b23d..e7bcd2366 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -589,6 +589,7 @@ src/builtin.h: src/genbuiltin $(builtin_sources)
>         $(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@
>
>  tools/%.rules:
> +       $(AM_V_at)$(MKDIR_P) tools
>         $(AM_V_GEN)cp $(srcdir)/$(subst 97-,,$@) $@
>
>  $(lib_libbluetooth_la_OBJECTS): $(local_headers)
> --
> 2.20.1

Applied, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 10:01 [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation Ross Burton
2019-10-09 15:01 ` Luiz Augusto von Dentz

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox