From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48817C43334 for ; Tue, 5 Jul 2022 17:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232512AbiGER0Y (ORCPT ); Tue, 5 Jul 2022 13:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232565AbiGER0W (ORCPT ); Tue, 5 Jul 2022 13:26:22 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8275920181; Tue, 5 Jul 2022 10:26:21 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id z21so21657518lfb.12; Tue, 05 Jul 2022 10:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0pQ6iR1EUoNTK7xjFYRM45QP5J5vl1BP+iXYidiRQmM=; b=SZoANr5ucaa007kirol6HgWRLWmSNZtzohchEqusEZPS5tWh7f2pnJALJ1QbcNz+nC ChfyPglkvPmoJ60XGHMo2yEmVHG3lgVFygPWFpmmgV16JwlFZB9hvN07O8oD6v8K9IXC SpzmazvCWv/n2cmmPXuSedj94gOglgsSgflmhWTckAw6+45KsCLswkNvVMWcaZzILPcc yQxTRSL+yH0WxL3cFBj5OFrTC/SXuUbhlb0GA5/URMu3N4k49BEt2SEswovawa7JwgD3 D4lQeueQBkc2iMQRmwL/p+MlKS2Hmsmq9+c++giFQ0h0zo7VngJ4Wl6gSPBtHBIyqUll g4pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0pQ6iR1EUoNTK7xjFYRM45QP5J5vl1BP+iXYidiRQmM=; b=zfCwByr9AG6MWZfYCweB+JQp+OihX/Cbf3d22AsNSbp0Q59u6HYznPisGmVaiGTprh /SliYuAalRGO/ec1C2U1m+iQoPXlt9k7CskkonM+EuBR1u44MC0Nacb2cb7ekjRHS1zr PvRiUfkj6tqXFYF97en2hCoHxuxv1asSrB7vEJafsyCp8d5gxkBO7fgKQlngL6em6Prz b0dGOgEH8oC+kvcq1TeySqxCUj7bL4i9Yi1MQAoE4J0jNjQw7TlRyZ/qw1jvJosjqVKS B8abM58QCVcVLv80lkKAhXcVJIJN2d83cLeLjvUQxLfEq36rV8Jf782b6OPfTpKihiI5 07nQ== X-Gm-Message-State: AJIora/QbyaSMRQBpMSSz5iQLZFBLHFwfytwwDM/gSvbGBD6v3H79rko sq8Z+bhAl0tZeYruPqPuYBAH6PmRTvD+Xsmc4eY= X-Google-Smtp-Source: AGRyM1tWng4bLriXfSk1WSsMNfdidVcDNLbP6dXIv1cqB7TlocrcpUtRMfF3kWR3xpVQZCPeuLFHdw9cxRVzUrFdews= X-Received: by 2002:a05:6512:108d:b0:481:6f3:e641 with SMTP id j13-20020a056512108d00b0048106f3e641mr22196430lfg.251.1657041979515; Tue, 05 Jul 2022 10:26:19 -0700 (PDT) MIME-Version: 1.0 References: <20220614181706.26513-1-max.oss.09@gmail.com> <20220705125931.3601-1-vasyl.vavrychuk@opensynergy.com> <20220705151446.GA28605@francesco-nb.int.toradex.com> In-Reply-To: <20220705151446.GA28605@francesco-nb.int.toradex.com> From: Luiz Augusto von Dentz Date: Tue, 5 Jul 2022 10:26:08 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: core: Fix deadlock due to `cancel_work_sync(&hdev->power_on)` from hci_power_on_sync. To: Francesco Dolcini Cc: Vasyl Vavrychuk , Linux Kernel Mailing List , "open list:NETWORKING [GENERAL]" , "linux-bluetooth@vger.kernel.org" , Max Krummenacher , =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= , Jakub Kicinski , Marcel Holtmann , max.krummenacher@toradex.com, Johan Hedberg , "David S. Miller" , Paolo Abeni , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi, On Tue, Jul 5, 2022 at 8:14 AM Francesco Dolcini wrote: > > Hello Vasyl, > > On Tue, Jul 05, 2022 at 03:59:31PM +0300, Vasyl Vavrychuk wrote: > > Fixes: commit dd06ed7ad057 ("Bluetooth: core: Fix missing power_on work cancel on HCI close") > > This fixes tag is broken, dd06ed7ad057 does not exist on > torvalds/master, and the `commit` word should be removed. > > Should be: > > Fixes: ff7f2926114d ("Bluetooth: core: Fix missing power_on work cancel on HCI close") Ive rebased the patch on top of bluetooth-next and fixed the hash, lets see if passes CI I might just go ahead and push it. -- Luiz Augusto von Dentz