Re: [PATCH v3 1/9] doc/media-api: Enable MediaEndpoint to expose remote SEP

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi Pali,

On Fri, Apr 5, 2019 at 7:47 PM Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Wednesday 23 January 2019 13:24:22 Luiz Augusto von Dentz wrote:
> > Hi Pali,
> > On Tue, Jan 22, 2019 at 7:56 PM Pali Rohár <pali.rohar@gmail.com> wrote:
> > >
> > > On Tuesday 22 January 2019 16:20:12 Luiz Augusto von Dentz wrote:
> > > > Hi Pali,
> > > > On Tue, Jan 22, 2019 at 3:45 PM Luiz Augusto von Dentz
> > > > <luiz.dentz@gmail.com> wrote:
> > > > >
> > > > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > > > >
> > > > > This adds the possibility to expose remote SEP using MediaEndpoint
> > > > > interface to allow setting a configuration.
> > > > > ---
> > > > >  doc/media-api.txt | 27 +++++++++++++++++++++++++--
> > > > >  1 file changed, 25 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/doc/media-api.txt b/doc/media-api.txt
> > > > > index b5ad2db12..af9485342 100644
> > > > > --- a/doc/media-api.txt
> > > > > +++ b/doc/media-api.txt
> > > > > @@ -500,14 +500,23 @@ Properties        object Player [readonly]
> > > > >  MediaEndpoint1 hierarchy
> > > > >  ========================
> > > > >
> > > > > -Service                unique name
> > > > > +Service                unique name (Server role)
> > > > > +               org.bluez (Client role)
> > > > >  Interface      org.bluez.MediaEndpoint1
> > > > > -Object path    freely definable
> > > > > +Object path    freely definable (Server role)
> > > > > +               [variable prefix]/{hci0,hci1,...}/dev_XX_XX_XX_XX_XX_XX/sepX
> > > > > +               (Client role)
> > > > >
> > > > >  Methods                void SetConfiguration(object transport, dict properties)
> > > > >
> > > > >                         Set configuration for the transport.
> > > > >
> > > > > +                       For client role transport must be set with a server
> > > > > +                       endpoint oject which will be configured and the
> > > > > +                       properties must contain the following properties:
> > > > > +
> > > > > +                               array{byte} Capabilities
> > > > > +
> > > > >                 array{byte} SelectConfiguration(array{byte} capabilities)
> > > > >
> > > > >                         Select preferable configuration from the supported
> > > > > @@ -532,6 +541,20 @@ Methods            void SetConfiguration(object transport, dict properties)
> > > > >                         endpoint, because when this method gets called it has
> > > > >                         already been unregistered.
> > > > >
> > > > > +Properties     string UUID [readonly, optional]:
> > > > > +
> > > > > +                       UUID of the profile which the endpoint is for.
> > > > > +
> > > > > +               byte Codec [readonly, optional]:
> > > > > +
> > > > > +                       Assigned number of codec that the endpoint implements.
> > > > > +                       The values should match the profile specification which
> > > > > +                       is indicated by the UUID.
> > > > > +
> > > > > +               array{byte} Capabilities [readonly, optional]:
> > > > > +
> > > > > +                       Capabilities blob, it is used as it is so the size and
> > > > > +                       byte order must match.
> > > > >
> > > > >  MediaTransport1 hierarchy
> > > > >  =========================
> > > > > --
> > > > > 2.17.2
> > > >
> > > > Can you try this set?
> > >
> > > Hi! In V3 you added only "a2dp: Add reverse discovery" patch right?
> > > I tested my setup also with this patch and there is no difference,
> > > pulseaudio is working fine :-)
> > >
> >
> > Applied.
> >
>
> Hello, I have found another problem with this patch series.
>
> I have there Nokia N900 device with Community SSU updates which acts as
> both A2DP sink and A2DP source.
>
> When I scan A2DP capabilities of Nokia N900 I get following output:
>
> $ ./tools/avinfo XX:XX:XX:XX:XX:XX
> Connecting ...
> Stream End-Point #1: Audio Source
>         Media Codec: SBC
>                 Channel Modes: Mono DualChannel Stereo JointStereo
>                 Frequencies: 16Khz 32Khz 44.1Khz 48Khz
>                 Subbands: 4 8
>                 Blocks: 4 8 12 16
>                 Bitpool Range: 2-64
> Stream End-Point #2: Audio Sink
>         Media Codec: SBC
>                 Channel Modes: Mono DualChannel Stereo JointStereo
>                 Frequencies: 16Khz 32Khz 44.1Khz 48Khz
>                 Subbands: 4 8
>                 Blocks: 4 8 12 16
>                 Bitpool Range: 2-64
>
> $ qdbus --system org.bluez
> /
> /org
> /org/bluez
> /org/bluez/hci0
> /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX
> /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/fd2
> /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/player0
> /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep1
> /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep2
> /org/bluez/test
>
> So there is one SEP as Audio Source and one SEP as Audio Sink.
>
> But when I ask sep1 and sep2 for UUID via dbus, I get that both are just
> Audio Sinks:
>
> $ qdbus --system org.bluez /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep1 org.bluez.MediaEndpoint1.UUID
> 0000110a-0000-1000-8000-00805f9b34fb
>
> $ qdbus --system org.bluez /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep2 org.bluez.MediaEndpoint1.UUID
> 0000110a-0000-1000-8000-00805f9b34fb
>
> So this is a clear bug.

I will send a fix shortly.

-- 
Luiz Augusto von Dentz